Page MenuHomeFreeBSD
Differential D57741

NULL pointer dereference in cat
AbandonedPublic
Actions

Authored by thebugfixers_pm.me on Mon, Jun 22, 12:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 16, 4:25 AM
Unknown Object (File)
Fri, Jul 3, 12:21 PM
Unknown Object (File)
Fri, Jul 3, 1:06 AM
Unknown Object (File)
Wed, Jul 1, 9:33 AM
Unknown Object (File)
Tue, Jun 30, 11:22 PM
Unknown Object (File)
Sun, Jun 28, 4:32 PM
Unknown Object (File)
Sat, Jun 27, 10:59 PM
Unknown Object (File)
Sat, Jun 27, 4:08 AM
View All 17 Files
Subscribers
imp
markj

Details

Reviewers
None
Group Reviewers
Src Committers
Contributor Reviews (src)
Summary

fdopen return value is not checked.

fp = fdopen(fd, "r");
cook_cat(fp);

fix: check fp == NULL and handle the error.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

thebugfixers_pm.me created this revision.Mon, Jun 22, 12:08 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 22, 12:09 PM
thebugfixers_pm.me requested review of this revision.Mon, Jun 22, 12:09 PM
markj added a subscriber: markj.Mon, Jun 22, 12:52 PM
markj added inline comments.
bin/cat/cat.c
268

This should be handled as a fatal error.

thebugfixers_pm.me updated this revision to Diff 180296.Mon, Jun 22, 1:40 PM

Per reviewer recommendation

thebugfixers_pm.me added a comment.Mon, Jun 22, 1:50 PM

Ignore that last diff (2). My bad. Updated version coming shortly.

thebugfixers_pm.me updated this revision to Diff 180297.Mon, Jun 22, 1:52 PM

Corrected version.

thebugfixers_pm.me abandoned this revision.Fri, Jun 26, 7:42 AM
thebugfixers_pm.me marked an inline comment as done.

Revision Contents
Changeset List

PathSize
bin/
cat/
6 lines

Diff 180297

View Options

bin/cat/cat.c

Loading...