Page MenuHomeFreeBSD

filesystems/pjdfstest: 0.2.2
ClosedPublic

Authored by asomers on Tue, Jun 16, 2:23 PM.
Tags
None
Referenced Files
F160174611: D57609.id179941.diff
Sun, Jun 21, 10:02 PM
F160155504: D57609.id179940.diff
Sun, Jun 21, 8:00 PM
F160115504: D57609.id179869.diff
Sun, Jun 21, 1:13 PM
F160115485: D57609.id179869.diff
Sun, Jun 21, 1:13 PM
Unknown Object (File)
Sat, Jun 20, 10:55 PM
Unknown Object (File)
Sat, Jun 20, 6:27 PM
Unknown Object (File)
Fri, Jun 19, 7:13 PM
Unknown Object (File)
Tue, Jun 16, 5:10 PM
Subscribers

Details

Summary

This release includes two changes:

  • Fixes the built on 32-bit platforms
  • Fixes the behavior on failure. Previously, the entire program would crash with SIGABRT.

https://github.com/saidsay-so/pjdfstest/blob/master/rust/CHANGELOG.md

Sponsored by: ConnectWise

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.

I applied this patch, built a pjdfstest-0.2.2 test package and installed it in a VM. Now pjdfstest just complains about a missing user:

root@freebsd:/usr/tests/sys/fs/pjdfstest # kyua test
tmpfs:tmpfs  ->  failed: atf-check failed; see the output of the test for details  [0.110s]
ufs:ufs1  ->  failed: atf-check failed; see the output of the test for details  [0.190s]
ufs:ufs2_nosu  ->  failed: atf-check failed; see the output of the test for details  [0.153s]
ufs:ufs2_su  ->  failed: atf-check failed; see the output of the test for details  [0.158s]
ufs:ufs2_suj  ->  failed: atf-check failed; see the output of the test for details  [0.172s]
zfs:zfs  ->  sysctl_register_oid: can't re-use a leaf (vfs.zfs.metaslab.condense_pct)!
ZFS filesystem version: 5
ZFS storage pool version: features support (5000)
failed: atf-check failed; see the output of the test for details  [0.882s]
zfs:zfs_nullfs  ->  failed: atf-check failed; see the output of the test for details  [0.196s]
p9fs:p9fs  ->  skipped: No p9fs shares configured  [0.069s]

Results file id is usr_tests_sys_fs_pjdfstest.20260616-144227-803467
Results saved to /root/.kyua/store/results.usr_tests_sys_fs_pjdfstest.20260616-144227-803467.db

0/8 passed (0 broken, 7 failed, 1 skipped)
root@freebsd:/usr/tests/sys/fs/pjdfstest # pjdfstest
error: pjdfstest: no such user
root@freebsd:/usr/tests/sys/fs/pjdfstest # kyua debug tmpfs:tmpfs
Executing command [ mkdir mnt ]
Executing command [ mount -t tmpfs none mnt ]
Executing command [ pjdfstest -c pjdfstest.toml -p mnt ]
Fail: incorrect exit status: 1, expected: 0
stdout:

stderr:
error: pjdfstest: no such user

Files left in work directory after failure: mnt, pjdfstest.toml
tmpfs:tmpfs  ->  failed: atf-check failed; see the output of the test for details
arrowd added inline comments.
filesystems/pjdfstest/Makefile
18

This should be LTO_UNSAFE=, see Mk/Features/lto.mk

WITH_/WITHOUT_${FEATURE} are user-facing knobs, ports should not define them.

I applied this patch, built a pjdfstest-0.2.2 test package and installed it in a VM. Now pjdfstest just complains about a missing user:

root@freebsd:/usr/tests/sys/fs/pjdfstest # kyua test
tmpfs:tmpfs  ->  failed: atf-check failed; see the output of the test for details  [0.110s]
ufs:ufs1  ->  failed: atf-check failed; see the output of the test for details  [0.190s]
ufs:ufs2_nosu  ->  failed: atf-check failed; see the output of the test for details  [0.153s]
ufs:ufs2_su  ->  failed: atf-check failed; see the output of the test for details  [0.158s]
ufs:ufs2_suj  ->  failed: atf-check failed; see the output of the test for details  [0.172s]
zfs:zfs  ->  sysctl_register_oid: can't re-use a leaf (vfs.zfs.metaslab.condense_pct)!
ZFS filesystem version: 5
ZFS storage pool version: features support (5000)
failed: atf-check failed; see the output of the test for details  [0.882s]
zfs:zfs_nullfs  ->  failed: atf-check failed; see the output of the test for details  [0.196s]
p9fs:p9fs  ->  skipped: No p9fs shares configured  [0.069s]

Results file id is usr_tests_sys_fs_pjdfstest.20260616-144227-803467
Results saved to /root/.kyua/store/results.usr_tests_sys_fs_pjdfstest.20260616-144227-803467.db

0/8 passed (0 broken, 7 failed, 1 skipped)
root@freebsd:/usr/tests/sys/fs/pjdfstest # pjdfstest
error: pjdfstest: no such user
root@freebsd:/usr/tests/sys/fs/pjdfstest # kyua debug tmpfs:tmpfs
Executing command [ mkdir mnt ]
Executing command [ mount -t tmpfs none mnt ]
Executing command [ pjdfstest -c pjdfstest.toml -p mnt ]
Fail: incorrect exit status: 1, expected: 0
stdout:

stderr:
error: pjdfstest: no such user

Files left in work directory after failure: mnt, pjdfstest.toml
tmpfs:tmpfs  ->  failed: atf-check failed; see the output of the test for details

I can't reproduce that failure. Check your pjdfstest.toml files. Is the "pjdfstest" user mentioned there?

I applied this patch, built a pjdfstest-0.2.2 test package and installed it in a VM. Now pjdfstest just complains about a missing user:

root@freebsd:/usr/tests/sys/fs/pjdfstest # kyua test
tmpfs:tmpfs  ->  failed: atf-check failed; see the output of the test for details  [0.110s]
ufs:ufs1  ->  failed: atf-check failed; see the output of the test for details  [0.190s]
ufs:ufs2_nosu  ->  failed: atf-check failed; see the output of the test for details  [0.153s]
ufs:ufs2_su  ->  failed: atf-check failed; see the output of the test for details  [0.158s]
ufs:ufs2_suj  ->  failed: atf-check failed; see the output of the test for details  [0.172s]
zfs:zfs  ->  sysctl_register_oid: can't re-use a leaf (vfs.zfs.metaslab.condense_pct)!
ZFS filesystem version: 5
ZFS storage pool version: features support (5000)
failed: atf-check failed; see the output of the test for details  [0.882s]
zfs:zfs_nullfs  ->  failed: atf-check failed; see the output of the test for details  [0.196s]
p9fs:p9fs  ->  skipped: No p9fs shares configured  [0.069s]

Results file id is usr_tests_sys_fs_pjdfstest.20260616-144227-803467
Results saved to /root/.kyua/store/results.usr_tests_sys_fs_pjdfstest.20260616-144227-803467.db

0/8 passed (0 broken, 7 failed, 1 skipped)
root@freebsd:/usr/tests/sys/fs/pjdfstest # pjdfstest
error: pjdfstest: no such user
root@freebsd:/usr/tests/sys/fs/pjdfstest # kyua debug tmpfs:tmpfs
Executing command [ mkdir mnt ]
Executing command [ mount -t tmpfs none mnt ]
Executing command [ pjdfstest -c pjdfstest.toml -p mnt ]
Fail: incorrect exit status: 1, expected: 0
stdout:

stderr:
error: pjdfstest: no such user

Files left in work directory after failure: mnt, pjdfstest.toml
tmpfs:tmpfs  ->  failed: atf-check failed; see the output of the test for details

I can't reproduce that failure. Check your pjdfstest.toml files. Is the "pjdfstest" user mentioned there?

I'm sorry, I had a leftover copy of the executable in an overlay that I use to build my test runner. It added the old copy to /bin/pjdfstest so the new version wasn't getting executed.

The new version seems to work fine, so I'll go ahead and commit the tests. Thanks to you and Sayafdine for all of the work on pjdfstest.

Great. And BTW, I'll apply @arrowd 's suggestion too. I can't update the diff. Lately, arc diff --update doesn't seem to work very well. Even if I haven't rebased my branch, that command complains that it's got far too many revisions to upload. I don't know why.

Great. And BTW, I'll apply @arrowd 's suggestion too. I can't update the diff. Lately, arc diff --update doesn't seem to work very well. Even if I haven't rebased my branch, that command complains that it's got far too many revisions to upload. I don't know why.

Have you tried git-arc? It's in tools/tools/git and in the ports tree as devel/freebsd-git-arc. I haven't used arc directly in a long time.

Great. And BTW, I'll apply @arrowd 's suggestion too. I can't update the diff. Lately, arc diff --update doesn't seem to work very well. Even if I haven't rebased my branch, that command complains that it's got far too many revisions to upload. I don't know why.

Have you tried git-arc? It's in tools/tools/git and in the ports tree as devel/freebsd-git-arc. I haven't used arc directly in a long time.

When using git-arc, do I need to squash my commits before updating phabricator? It sounds like it, based on the man page's "git arc assumes a one-to-one relationship between git commits and Differential Revisions"

Great. And BTW, I'll apply @arrowd 's suggestion too. I can't update the diff. Lately, arc diff --update doesn't seem to work very well. Even if I haven't rebased my branch, that command complains that it's got far too many revisions to upload. I don't know why.

Have you tried git-arc? It's in tools/tools/git and in the ports tree as devel/freebsd-git-arc. I haven't used arc directly in a long time.

When using git-arc, do I need to squash my commits before updating phabricator? It sounds like it, based on the man page's "git arc assumes a one-to-one relationship between git commits and Differential Revisions"

You mean fixup commits? Yes, they need to be squashed before updating.

  • fixup: use LTO_UNSAFE instead of WITHOUT_LTO

Ok, git arc worked after squashing my commits.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jun 17, 5:50 PM
This revision was automatically updated to reflect the committed changes.

Ok, git arc worked after squashing my commits.

Come to think about it, it'd be pretty handy if git arc update ran git rebase --autosquash on the commit before the first commit in the specified range...