Page MenuHomeFreeBSD

fix(acpi_panasonic): acquire serial lock before calling hkey_sound_mute in shutdown
ClosedPublic

Authored by guest-seuros on Apr 29 2026, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 27, 2:57 PM
Unknown Object (File)
Fri, Jun 26, 3:26 PM
Unknown Object (File)
Fri, Jun 26, 1:04 PM
Unknown Object (File)
Thu, Jun 25, 8:45 AM
Unknown Object (File)
Thu, Jun 18, 2:24 AM
Unknown Object (File)
Thu, Jun 4, 7:16 AM
Unknown Object (File)
Thu, Jun 4, 7:15 AM
Unknown Object (File)
May 30 2026, 5:33 PM
Subscribers

Details

Summary

acpi_panasonic_shutdown() calls hkey_sound_mute() without holding the ACPI serial lock.
Every other call site holds ACPI_SERIAL_BEGIN(panasonic) before calling it, as the locking model is caller-owned.

This seems to affect the whole Panasonic Toughtbook lineup btw.

Test Plan

Boot a Panasonic Notebook with acpi_panasonic loaded. Trigger a clean shutdown and reboot, verify no static audio burst through the speaker.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

guest-seuros held this revision as a draft.
guest-seuros edited the summary of this revision. (Show Details)
guest-seuros edited the test plan for this revision. (Show Details)
guest-seuros added a reviewer: imp.

hkey_sound_mute calls ACPI_SERIAL_ASSERT(..), which I assume is where things panic. This is a pretty straightforward change.

This revision is now accepted and ready to land.May 5 2026, 7:47 PM