Page MenuHomeFreeBSD

bnxt_en: Address review comments for core SR-IOV support
ClosedPublic

Authored by chandrakanth.patil_broadcom.com on Apr 26 2026, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 25, 11:00 AM
Unknown Object (File)
Mon, May 25, 11:00 AM
Unknown Object (File)
Wed, May 20, 3:25 AM
Unknown Object (File)
Tue, May 19, 9:22 PM
Unknown Object (File)
Tue, May 19, 10:28 AM
Unknown Object (File)
Tue, May 19, 10:23 AM
Unknown Object (File)
Mon, May 18, 6:35 PM
Unknown Object (File)
Sun, May 17, 7:20 PM
Subscribers

Details

Summary

Address review comments from the initial SR-IOV support patch.

This change includes the following updates:

  • Rename the P7 VF PCI ID macro from NETXTREME_E_P7_VF to E_P7_VF, since the P7/Thor2 product strings no longer use the NetXtreme name. Other VF device IDs are unchanged.
  • Make bnxt_vf_parse_schema() return a boolean value and use that return value in bnxt_iov_vf_add() to decide whether bnxt_set_vf_admin_mac() should be called. This also removes the separate has_admin_mac field.
  • Fix indentation in bnxt_free_vf_resources() after dma_free_coherent(), so the NULL assignment is clearly separate from the function call.
  • Update bnxt_hwrm_func_vf_resource_free() to use first_vf_id and last_vf_id while looping through HWRM_FUNC_VF_RESC_FREE.

This patch addresses the code review comments provided for:
https://reviews.freebsd.org/D56197

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable