ctld: normalize iSCSI TargetName on login
Needs ReviewPublic
Actions

Authored by js on Fri, Apr 17, 2:04 PM.

Details

Reviewers

jhb
asomers

Summary

Case-insensitive TargetName matching on logins was accidentally removed, let's fix that by normalizing TargetName again according to RFC 3722.

PR: 294522
Fixes: 4b1aac931465f39c5c26bfa1d5539a428d340f20
Sponsored by: ConnectWise
MFC after: 1 week

Test Plan

Tested by using the following ctl.conf:

portal-group pg0 {
  listen 127.0.0.1
  discovery-auth-group no-authentication
}
auth-group ag0 {
  auth-type none
}
target iqn.2018-10.myhost-test {
  auth-group ag0
  portal-group pg0
}

and connecting to the share using iscsictl -A -t iqn.2018-10.MyHoSt-TeSt -p localhost -e on (and other variations).

Also ran ctladm test suite, all tests passed.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

js created this revision.Fri, Apr 17, 2:04 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 17, 2:04 PM

js requested review of this revision.Fri, Apr 17, 2:04 PM

This looks good to me. But one question: do we need to do the same for NVMEoF?

I don't know if there is a normalization requirement for nqn. I'll see if I can find something while I wait on review from jhb.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

10 lines

Diff 175749

View Options

ctld: normalize iSCSI TargetName on loginNeeds ReviewPublicActions