Page MenuHomeFreeBSD
Differential D5646

[BHND] Union should be named according to C99. It allows to compile code under MIPS
AbandonedPublic
Actions

Authored by mizhka on Mar 16 2016, 8:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 9:12 AM
Unknown Object (File)
Feb 10 2024, 8:50 PM
Unknown Object (File)
Jan 11 2024, 9:53 AM
Unknown Object (File)
Dec 21 2023, 2:38 AM
Unknown Object (File)
Dec 20 2023, 12:42 AM
Unknown Object (File)
Sep 6 2023, 10:09 AM
Unknown Object (File)
Aug 18 2023, 5:52 AM
Unknown Object (File)
Jul 25 2023, 7:04 AM
View All 34 Files
Subscribers
imp

Details

Reviewers
landon_landonf.org
adrian
Summary

Unnamed unions are allowed in C11, but it's a pity that cross-compiler for MIPS is GCC4.2.1, which doesn't support C11. This patch add name for the only union.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mizhka updated this revision to Diff 14353.Mar 16 2016, 8:42 AM
mizhka retitled this revision from to [BHND] Union should be named according to C99. It allows to compile code under MIPS.
mizhka updated this object.
mizhka edited the test plan for this revision. (Show Details)
mizhka added reviewers: landon_landonf.org, adrian.
mizhka set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMar 16 2016, 8:42 AM
mizhka updated this revision to Diff 14354.Mar 16 2016, 8:47 AM

now it's correct diff )

landon_landonf.org edited edge metadata.Mar 16 2016, 6:09 PM

Other than the minor /**, looks good to me.

sys/dev/bhnd/bhndb/bhndb.h
83

Should remove the ** (double asterisk) here; that marks the comment as API documentation when parsed by doxygen/libclang.

mizhka abandoned this revision.Apr 25 2016, 8:37 AM
imp added inline comments.Apr 26 2016, 2:43 AM
sys/dev/bhnd/bhndb/bhndb.h
84

Do you need both the union name and the field name?

Revision Contents
Changeset List

PathSize
sys/
dev/
bhnd/
bhndb/
8 lines
4 lines
4 lines
38 lines
22 lines

Diff 14354

View Options

sys/dev/bhnd/bhndb/bhndb.h

Loading...
View Options

sys/dev/bhnd/bhndb/bhndb.c

Loading...
View Options

sys/dev/bhnd/bhndb/bhndb_pci.c

Loading...
View Options

sys/dev/bhnd/bhndb/bhndb_pci_hwdata.c

Loading...
View Options

sys/dev/bhnd/bhndb/bhndb_subr.c

Loading...