Page MenuHomeFreeBSD

usr.bin/gh-bc/tests: double bc tests timeout
AcceptedPublic

Authored by siva on Sat, Apr 11, 1:45 PM.

Details

Reviewers
lwhsu
se
Summary

Fails due to timeout in CI on emulated architectures:
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16565/testReport/usr.bin.gh-bc/

Tested locally, definitely should pass with double the timeout (for now).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72132
Build 69015: arc lint + arc unit

Event Timeline

siva requested review of this revision.Sat, Apr 11, 1:45 PM

Usually I'm not a fan of increasing timeout but I think we should do it in this case.

This revision is now accepted and ready to land.Sat, Apr 11, 2:19 PM

The tests complete in 3 seconds on my amd64 system.
I do assume that the 100 times slower execition on riscv64 is due to inefficient emulation of that platform?
Instead of patching the timeout in individual ports, I believe the parameters in the CI system should be adjusted to account for the slow execution speed of emulated systems.
Therefore, I do not want to set the timeout to such a high value for all platforms.
If there is consensus that changing individual ports is required, I'd make the timeout adjustment depend on the architecture (apparently, only riscv64 is affected).

In D56354#1289604, @se wrote:

The tests complete in 3 seconds on my amd64 system.
I do assume that the 100 times slower execition on riscv64 is due to inefficient emulation of that platform?
Instead of patching the timeout in individual ports, I believe the parameters in the CI system should be adjusted to account for the slow execution speed of emulated systems.
Therefore, I do not want to set the timeout to such a high value for all platforms.
If there is consensus that changing individual ports is required, I'd make the timeout adjustment depend on the architecture (apparently, only riscv64 is affected).

Yes this is indeed a better idea. I would say for now the easiest way is set another default timeout value in test vm's /etc/kyua/kyua.conf , but updating the "build test vm" job conf for riscv64. It's not as simple as this one, but might be better to overcome this issue, even in other test cases.