Differential D5627

Switch autofs to use rbtrees instead of linear searches.
ClosedPublic
Actions

Authored by trasz on Mar 13 2016, 9:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 20, 4:54 AM

	Unknown Object (File)
	Sat, Oct 19, 12:16 AM

	Unknown Object (File)
	Oct 2 2024, 8:08 AM

	Unknown Object (File)
	Sep 25 2024, 8:40 AM

	Unknown Object (File)
	Sep 24 2024, 9:58 PM

	Unknown Object (File)
	Sep 22 2024, 12:55 AM

	Unknown Object (File)
	Sep 16 2024, 1:11 PM

	Unknown Object (File)
	Sep 9 2024, 3:30 AM

View All 41 Files

Subscribers

Details

Reviewers

Commits

rS297236: Speed up lookups in autofs(5) by using red-black trees instead of linear

Summary

Speed up lookups in autofs(5) by using red-black trees instead of linear
searches.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz updated this revision to Diff 14300.Mar 13 2016, 9:39 PM

trasz retitled this revision from to Switch autofs to use rbtrees instead of linear searches..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptMar 13 2016, 9:39 PM

trasz added a reviewer: kib.Mar 14 2016, 4:42 PM

kib added inline comments.Mar 14 2016, 5:00 PM

sys/fs/autofs/autofs_vfsops.c
162 ↗	(On Diff #14300)	Why not use RB_FOREACH(_SAFE) ?

trasz added inline comments.Mar 14 2016, 7:08 PM

sys/fs/autofs/autofs_vfsops.c
162 ↗	(On Diff #14300)	I'm not sure that would work. What this does, basically, is it goes to the first leaf node found, deletes it, and loops around. So, in the top level loop we usually iterate over each element more than once.

kib accepted this revision.Mar 24 2016, 10:54 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Mar 24 2016, 10:54 AM

Closed by commit rS297236: Speed up lookups in autofs(5) by using red-black trees instead of linear (authored by trasz). · Explain WhyMar 24 2016, 1:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

autofs/

7 lines

10 lines

autofs_vfsops.c

9 lines

38 lines

Diff 14574

head/sys/fs/autofs/autofs.h

Loading...

head/sys/fs/autofs/autofs.c

Loading...

head/sys/fs/autofs/autofs_vfsops.c

Loading...

head/sys/fs/autofs/autofs_vnops.c

Loading...