Page MenuHomeFreeBSD
Differential D56160

snd_uaudio: Retire sndcard_func usage
ClosedPublic
Actions

Authored by christos on Mon, Mar 30, 12:03 PM.

Details

Reviewers
markj
emaste
Commits
rG0efd33382504: snd_uaudio: Retire sndcard_func usage
Summary

This is effectively a no-op, as it does not make use of the
sndcard_func->varinfo field, so eventually ua_probe() always succeeds.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Mon, Mar 30, 12:03 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 30, 12:03 PM
christos requested review of this revision.Mon, Mar 30, 12:03 PM
Harbormaster completed remote builds in B71817: Diff 174527.Mon, Mar 30, 12:03 PM
markj added inline comments.Mon, Mar 30, 12:23 PM
sys/dev/sound/usb/uaudio_pcm.c
193

Why did you change from BUS_PROBE_DEFAULT to 0?

christos added inline comments.Mon, Mar 30, 12:26 PM
sys/dev/sound/usb/uaudio_pcm.c
193

This is the pcm driver, it does not correspond to a real device, but to a sound(4) device. Other drivers do the same already. Is there a reason to have BUS_PROBE_DEFAULT in this case?

christos added inline comments.Mon, Mar 30, 12:29 PM
sys/dev/sound/usb/uaudio_pcm.c
193

Correction, not "correspond", but "probe".

markj accepted this revision.Mon, Mar 30, 12:42 PM
markj added inline comments.
sys/dev/sound/usb/uaudio_pcm.c
193

I don't see a reason not to use 0 now that I see that ua_pcm devices are attached using bus_attach_children(), but the review description doesn't mention this change, so I can't easily see if it's intentional.

This revision is now accepted and ready to land.Mon, Mar 30, 12:42 PM
christos added inline comments.Mon, Mar 30, 12:43 PM
sys/dev/sound/usb/uaudio_pcm.c
193

I'll update the description. Thanks :)

Closed by commit rG0efd33382504: snd_uaudio: Retire sndcard_func usage (authored by christos). · Explain WhyMon, Mar 30, 2:13 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG0efd33382504: snd_uaudio: Retire sndcard_func usage.

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
usb/
5 lines
13 lines

Diff 174546

View Options

sys/dev/sound/usb/uaudio.c

Loading...
View Options

sys/dev/sound/usb/uaudio_pcm.c

Loading...