Page MenuHomeFreeBSD
Differential D5612

Replace Makefile.lib32 with generalized Makefile.libcompat.
ClosedPublic
Actions

Authored by bdrewery on Mar 11 2016, 8:28 PM.
Tags
None
Referenced Files
F105883557: D5612.diff
Sun, Dec 22, 2:49 AM
Unknown Object (File)
Tue, Dec 10, 12:00 AM
Unknown Object (File)
Sat, Dec 7, 9:45 AM
Unknown Object (File)
Thu, Dec 5, 4:30 AM
Unknown Object (File)
Wed, Dec 4, 12:22 AM
Unknown Object (File)
Thu, Nov 28, 7:05 PM
Unknown Object (File)
Fri, Nov 22, 1:28 PM
Unknown Object (File)
Nov 20 2024, 10:56 AM
View All Files
Subscribers
None

Details

Reviewers
emaste
imp
Commits
rS296709: Move Makefile.lib32 to Makefile.libcompat and generalize it.
Summary

It only supports 1 libcompat type so far. No looping or multi-inclusion
supported yet since we don't need that.

Test Plan

Running buildworld now

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdrewery updated this revision to Diff 14246.Mar 11 2016, 8:28 PM
bdrewery retitled this revision from to Replace Makefile.lib32 with generalized Makefile.libcompat..
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
bdrewery added reviewers: imp, emaste.
bdrewery updated this revision to Diff 14247.Mar 11 2016, 8:31 PM

Make this a diff against Makefile.lib32

bdrewery updated this revision to Diff 14248.Mar 11 2016, 8:32 PM

Meant to have Makefile.inc1 not Makefile

bdrewery added inline comments.Mar 11 2016, 8:35 PM
Makefile.libcompat
44 ↗(On Diff #14248)

I would leave out this section and let you commit it with D5605

bdrewery updated this revision to Diff 14252.Mar 11 2016, 9:20 PM
  • Fix LIB32TMP / LIB32WMAKE references by generalizing more. This makes most of D5605 not needed. It now only needs to add the logic to include Makefile.libcompat with LIBCOMPAT=SOFT and add the right bits to Makefile.libcompat.
bdrewery updated this revision to Diff 14254.Mar 11 2016, 9:27 PM

Fix more invalid references to removed LIB32*

bdrewery updated this revision to Diff 14255.Mar 11 2016, 9:56 PM

Fix LIBCOMPATTMP and LIBCOMPAT_OBJTREE being empty, leading to wrong compiler and no DESTDIR during build.

bdrewery updated this revision to Diff 14257.Mar 11 2016, 9:59 PM

Fix use of empty() - no real change though as it was properly set before this

bdrewery added a comment.Mar 11 2016, 10:51 PM

With the latest version buildworld/installworld seem fine and nothing is leaking outside of DESTDIR.

Closed by commit rS296709: Move Makefile.lib32 to Makefile.libcompat and generalize it. (authored by bdrewery). · Explain WhyMar 11 2016, 11:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
58 lines
136 lines
152 lines

Diff 14259

View Options

head/Makefile.inc1

Loading...
View Options

head/Makefile.lib32

Loading...
View Options

head/Makefile.libcompat

Loading...