Page MenuHomeFreeBSD
Differential D55994

acpi_apm: Narrow scope of ACPI_LOCK
AcceptedPublic
Actions

Authored by jhb on Fri, Mar 20, 4:46 PM.

Details

Reviewers
jkim
markj
Summary

This lock doesn't need to be held across seldrain/knlist_destroy. It
is also redundant (and a bug) to hold it across knlist_add and
knlist_remove since it is the mutex for the knlist.

PR: 293901

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71591
Build 68474: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, Mar 20, 4:46 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Mar 20, 4:46 PM
jhb requested review of this revision.Fri, Mar 20, 4:46 PM
Harbormaster completed remote builds in B71591: Diff 174023.Fri, Mar 20, 4:46 PM
markj accepted this revision.Sat, Mar 21, 2:25 AM
markj added inline comments.
sys/x86/acpica/acpi_apm.c
413

I guess an alternate solution would be to make the last parameter 1 instead of 0? But I don't see much reason to acquire the lock here anyway.

This revision is now accepted and ready to land.Sat, Mar 21, 2:25 AM

Revision Contents
Changeset List

PathSize
sys/
x86/
acpica/
8 lines

Diff 174023

View Options

sys/x86/acpica/acpi_apm.c

Loading...