Page MenuHomeFreeBSD
Differential D5598

Implement AUXILIARY REGISTER
ClosedPublic
Actions

Authored by imp on Mar 9 2016, 9:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 19 2024, 10:15 PM
Unknown Object (File)
Nov 14 2024, 4:43 PM
Unknown Object (File)
Sep 29 2024, 11:32 PM
Unknown Object (File)
Sep 27 2024, 12:11 PM
Unknown Object (File)
Sep 27 2024, 7:28 AM
Unknown Object (File)
Sep 25 2024, 9:55 AM
Unknown Object (File)
Sep 24 2024, 11:13 PM
Unknown Object (File)
Sep 24 2024, 9:48 AM
View All Files
Subscribers
None

Details

Reviewers
scottl
ken
Commits
rS298143: Implement Auxiliary register. Add PIM_ATA_EXT flag to flag that a SIM
rS298142: tag_action is not used at all in ata. It's set to 1 for ordered
Summary

tag_action is not used at all in ata. It's set to 1 for ordered
transactions, but that value isn't used. It's bogusly used to report
in devstat, due to a cut and paste error from SCSI. Mark it as unused
in cam_fill_ataio. Reclaim the memory as a new ata_flags. In addition,
tag_id and init_id are completely unused, so reclaim those as 'unused'
now too. These were needlessly copied when ata was split from scsi.

This allows us, in the future, to create structures that can
communicate AUXILIARY regsiter to the SIMs, which cannot be done now.

Implement Auxiliary register. Add PIM_ATA_EXT flag to flag that a SIM
can handle it, and add the code to add it to the FIS that's sent to
the drive. The mvs driver is the only other ATA driver in the system,
and its hardware doesn't appear to support setting the Auxiliary
register.

Test Plan

Note: This is done as two commits: 1 to GC the old members, and one to implement this.

Also, Scott and I talked about having a ata_cmd_ext that would have this new data. I'm still cooking on that idea.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp updated this revision to Diff 14201.Mar 9 2016, 9:58 PM
imp retitled this revision from to Implement AUXILIARY REGISTER.
imp updated this object.
imp edited the test plan for this revision. (Show Details)
imp edited the test plan for this revision. (Show Details)Mar 9 2016, 10:00 PM
imp added reviewers: scottl, ken.
imp updated this revision to Diff 14202.Mar 9 2016, 10:04 PM
  • tag_action is not used at all in ata. It's set to 1 for ordered
  • Implement Auxiliary register. Add PIM_ATA_EXT flag to flag that a SIM
scottl edited edge metadata.Mar 9 2016, 10:08 PM

If the PIM_ATA_EXT flag is getting set by the SIM and checked by the periph, it would be a programming error for the periph to set the ATA_FLAG_AUX flag if PIM_ATA_EXT was not set. Therefore, maybe make the check for ATA_FLAG_AUX be a KASSERT instead of a mandatory runtime check?

scottl added inline comments.Mar 9 2016, 10:10 PM
sys/dev/ahci/ahci.c
2428 ↗(On Diff #14202)

My brain alway takes a long time to think about endianness. Will this be ok on big-endian architectures?

imp updated this revision to Diff 14203.Mar 9 2016, 10:11 PM
imp edited edge metadata.

Per scott, kassert programming error.

  • tag_action is not used at all in ata. It's set to 1 for ordered
  • Implement Auxiliary register. Add PIM_ATA_EXT flag to flag that a SIM
sys/dev/ahci/ahci.c
2428 ↗(On Diff #14203)

No. This is how you don't break big endian architectures.

imp updated this revision to Diff 14204.Mar 9 2016, 10:45 PM

Turns out there's 4 ata drivers in the system, not 3. Make sure we
don't get any AUXILIARY requests.

Closed by commit rS298142: tag_action is not used at all in ata. It's set to 1 for ordered (authored by imp). · Explain WhyApr 17 2016, 5:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
cam/
ata/
2 lines
15 lines
2 lines
scsi/
2 lines

Diff 15275

View Options

head/sys/cam/ata/ata_da.c

Loading...
View Options

head/sys/cam/cam_ccb.h

Loading...
View Options

head/sys/cam/cam_periph.c

Loading...
View Options

head/sys/cam/scsi/scsi_pass.c

Loading...