Differential D55989

sound: Remove SND_DIAGNOSTIC section in buffer.c
ClosedPublic
Actions

Authored by christos on Fri, Mar 20, 1:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 27, 8:02 AM

	Unknown Object (File)
	Wed, Mar 25, 11:43 PM

	Unknown Object (File)
	Sun, Mar 22, 8:58 PM

Subscribers

Details

Reviewers

markj
emaste

Commits

rG4324e0fa71f8: sound: Remove SND_DIAGNOSTIC section in buffer.c

Summary

The purpose of this has not been documented, but it seems like it makes
it possible to view the maximum number of bytes that passed to
sndbuf_feed(), as well as the maximum number of cycles taken inside its
main loop. These do not seem particularly useful anymore.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Fri, Mar 20, 1:09 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Mar 20, 1:09 PM

christos requested review of this revision.Fri, Mar 20, 1:09 PM

Harbormaster completed remote builds in B71586: Diff 174010.Fri, Mar 20, 1:09 PM

markj accepted this revision.Sat, Mar 21, 3:45 AM

This revision is now accepted and ready to land.Sat, Mar 21, 3:45 AM

Closed by commit rG4324e0fa71f8: sound: Remove SND_DIAGNOSTIC section in buffer.c (authored by christos). · Explain WhyTue, Mar 24, 10:39 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG4324e0fa71f8: sound: Remove SND_DIAGNOSTIC section in buffer.c.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

26 lines

Diff 174220

sys/dev/sound/pcm/buffer.c

Loading...