Page MenuHomeFreeBSD

rge: use C style comments instead of C++
ClosedPublic

Authored by chris.longros_gmail.com on Mar 8 2026, 3:35 PM.
Referenced Files
Unknown Object (File)
Sun, May 10, 1:37 PM
Unknown Object (File)
Sun, May 10, 1:27 PM
Unknown Object (File)
Sun, May 10, 4:35 AM
Unknown Object (File)
Sun, May 10, 4:27 AM
Unknown Object (File)
Sun, May 10, 4:11 AM
Unknown Object (File)
Sun, May 10, 4:07 AM
Unknown Object (File)
Sat, May 9, 6:24 PM
Unknown Object (File)
Sat, May 9, 6:18 PM
Subscribers

Details

Summary

FreeBSD style(9) mandates C style comments. The initial import from
OpenBSD left several C++ style // comments in if_rge.c and if_rgevar.h.
Replace them with proper /* */ comments.

Also fix a malformed comment that mixed // with a closing */.

Signed-off-by: Christos Longros <chris.longros@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Lemme see which I can delete and which I need to keep and use.

I /think/ the commented out fields in if_rgevar.h can just be deleted. Would you mind just deleting those fields and resubmitting the diff?

Thanks!

I deleted the 4 commented-out struct members from if_rgevar.h (if_rxring, pci_intr_handle_t, pci_chipset_tag_t, pcitag_t).

This revision is now accepted and ready to land.Mar 15 2026, 4:13 PM
This revision was automatically updated to reflect the committed changes.