Page MenuHomeFreeBSD
Differential D55498

exterr: support for EXTERROR_VERBOSE=brief
AbandonedPublic
Actions

Authored by kib on Wed, Feb 25, 5:44 AM.
Tags
None
Referenced Files
F146247401: D55498.id172649.diff
Sun, Mar 1, 2:25 AM
Unknown Object (File)
Wed, Feb 25, 9:09 PM
Unknown Object (File)
Wed, Feb 25, 3:50 PM
Unknown Object (File)
Wed, Feb 25, 2:01 PM
Unknown Object (File)
Wed, Feb 25, 1:37 PM
Unknown Object (File)
Wed, Feb 25, 12:19 PM
Unknown Object (File)
Wed, Feb 25, 11:14 AM
Subscribers
imp

Details

Reviewers
mckusick
Summary

Based on the https://reviews.freebsd.org/D55494 by mckusick.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Wed, Feb 25, 5:44 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 25, 5:44 AM
kib requested review of this revision.Wed, Feb 25, 5:44 AM
kib mentioned this in D55494: Refinement to kernel extended error reporting.
mckusick added a comment.Wed, Feb 25, 9:29 PM

If you don't have kernel strings, you need to print the long form.

I have incorporated your changes plus the above fix into my original review (D55494) along with updates to the manual page. If you are happy with that I will commit it.

lib/libc/gen/uexterr_format.c
91–92

In the !has_msg case, you are not printing anything. This needs to add || !has_msg.

kib abandoned this revision.Thu, Feb 26, 7:23 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
27 lines

Diff 172649

View Options

lib/libc/gen/uexterr_format.c

Loading...