nvmf_che: Don't leak a socket if an error occurs finalizing the socket
Needs ReviewPublic
Actions

Authored by jhb on Tue, Feb 24, 8:20 PM.

Tags

None

Referenced Files

	F146305468: D55493.id.diff
	Sun, Mar 1, 2:24 PM

	F146262299: D55493.id172623.diff
	Sun, Mar 1, 5:15 AM

	F146247432: D55493.id172623.diff
	Sun, Mar 1, 2:26 AM

	Unknown Object (File)
	Wed, Feb 25, 7:14 AM

	Unknown Object (File)
	Wed, Feb 25, 6:54 AM

	Unknown Object (File)
	Wed, Feb 25, 1:58 AM

	Unknown Object (File)
	Tue, Feb 24, 9:09 PM

Subscribers

imp

Details

Reviewers

Summary

If soreserve() or sosetopt() (to set TCP_NODELAY) fails after claiming
the socket from the file descriptor, explicitly close the socket before
returning failure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70971
Build 67854: arc lint + arc unit

Event Timeline

jhb created this revision.Tue, Feb 24, 8:20 PM

Herald added subscribers: ae, imp. · View Herald TranscriptTue, Feb 24, 8:20 PM

jhb requested review of this revision.Tue, Feb 24, 8:20 PM

Harbormaster completed remote builds in B70971: Diff 172623.Tue, Feb 24, 8:20 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

nvmf/

nvmf_che.c

1 line

Diff 172623

View Options

sys/dev/cxgbe/nvmf/nvmf_che.c

nvmf_che: Don't leak a socket if an error occurs finalizing the socketNeeds ReviewPublicActions