Page MenuHomeFreeBSD

nvidia comments: Wordsmith
AcceptedPublic

Authored by ziaee on Mon, Feb 23, 3:38 AM.

Details

Summary

These days, Nvidia graphics is more platforms than just cards, more
renderers than just OpenGL, and more display protocols than just X.
This increases external consistency, clarity, and eliminates jarring
line wrapping at reference column width 80.

This is also a good time to decide how to correct capitalization. Do we
use "Nvidia", what the company calls themselves in text, or "NVIDIA",
how they stylize it in their logo? I don't see external use of "NVidia".
Search is case insensitive either way, but it looks unofficial to be
capitalized differently than everywhere else..

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70923
Build 67806: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Mon, Feb 23, 3:38 AM
ziaee created this revision.

Move linuxulator port back to parenthetical quotes, matching other linuxulator ports.

Overall I am fine with it, provided suggestions about the master driver and kmod

x11/nvidia-driver/Makefile
24

I would probably just call this Nvidia graphics driver userland

x11/nvidia-kmod/Makefile
24

Likewise something like Nvidia driver kernel module

Use "Nvidia" capitalization on the other three nvidia ports. I'm happy to do them the other way if that's what we want, I have no attachment to either style, just that they should all be the same.

ziaee added inline comments.
graphics/egl-x11/Makefile
7

When I went on their github, I discovered that the point of this port is XWayland

x11/nvidia-xconfig/Makefile
6

We might want to say something like this to make it really clear.

The capitalization we normally use is NVIDIA, at least these days. I believe all of our official docs follow that but there's plenty of people who don't and it's not that big of a deal. I would recommend "NVIDIA".

switch nvidia to uppercase, thanks @ashafer!

This revision is now accepted and ready to land.Mon, Feb 23, 5:34 PM

Wanted to know how ashafer thinks before accepting. Now it LGTM.

I still need the non-x11@ maintainers a few days to accept this. Hopefully they wont make me file bugs to point to this.