nvidia comments: Wordsmith

[ziaee]

Summary

These days, Nvidia graphics is more platforms than just cards, more
renderers than just OpenGL, and more display protocols than just X.
It's also written in uppercase. This increases consistency, clarity,
and eliminates jarring line wrapping at reference column width 80.

PR:                     293473 (graphics/nvidia-texture-tools)
PR:                     293474 (sysutils/nvclock)
PR:                     293475 (sysutils/py-nvitop)
Reviewed by:            ashafer, kbowling, junchoon_dec.sakura.ne.jp
Differential Revision:  https://reviews.freebsd.org/D55452

[ziaee]

Move linuxulator port back to parenthetical quotes, matching other linuxulator ports.

[kbowling]

Overall I am fine with it, provided suggestions about the master driver and kmod

x11/nvidia-driver/Makefile

24

I would probably just call this Nvidia graphics driver userland

x11/nvidia-kmod/Makefile

24

Likewise something like Nvidia driver kernel module

[ziaee]

Thanks @kbowling, that's a lot clearer!

[ziaee]

Use "Nvidia" capitalization on the other three nvidia ports. I'm happy to do them the other way if that's what we want, I have no attachment to either style, just that they should all be the same.

[ziaee]

Add a few more

[ziaee]

graphics/egl-x11/Makefile

7

When I went on their github, I discovered that the point of this port is XWayland

x11/nvidia-xconfig/Makefile

6

We might want to say something like this to make it really clear.

[ziaee]

added nvclock

[ashafer]

The capitalization we normally use is NVIDIA, at least these days. I believe all of our official docs follow that but there's plenty of people who don't and it's not that big of a deal. I would recommend "NVIDIA".

[ziaee]

switch nvidia to uppercase, thanks @ashafer!

[junchoon_dec.sakura.ne.jp]

Wanted to know how ashafer thinks before accepting. Now it LGTM.

[ziaee]

I still need the non-x11@ maintainers a few days to accept this. Hopefully they wont make me file bugs to point to this.

[danfe]

Looks good; I also like how some previously overly long comments had been reworded for clarity and brevity.

[ziaee]

Thanks Tomoaki!
Thanks Danfe!

[ziaee]

• add egl-wayland/egl-wayland2 and work on egl/x11 to match/add xcb/xlib

[ziaee]

Also note that pkg search was made case sensitive in pkg 2.5.0.

graphics/egl-wayland2/Makefile

7

Note that dma-buf appears to be lowercase

https://docs.kernel.org/driver-api/dma-buf.html

[junchoon_dec.sakura.ne.jp]

Updates LGTM.