graphics/egl-wayland2: Add new port
ClosedPublic
Actions

Authored by junchoon_dec.sakura.ne.jp on Tue, Mar 10, 1:43 PM.

Details

Reviewers

kbowling
ashafer
danfe

Group Reviewers

x11

Commits

R11:b23b14c3bfc0: graphics/egl-wayland2: New port

Summary

Introduce graphics/egl-wayland2, Wayland EGL External Platform library
Version 2 that works with NVIDIA drivers 560 and later.

This is a new implementation of the EGL External Platform Library
for Wayland (EGL_KHR_platform_wayland), using the NVIDIA driver's
new platform surface interface (Dma-buf-based), which simplifies
a lot of the library and improves window resizing.

This library can be installed alongside the previous egl-wayland
implementation (graphics/egl-wayland).

The new library has a higher selection priority by default,
so if both are present, then a 560 or later driver will select
the new library, and an older driver will fall back to the old
library.

PR: 293719

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

junchoon_dec.sakura.ne.jp requested review of this revision.Tue, Mar 10, 1:43 PM

junchoon_dec.sakura.ne.jp created this revision.

ziaee added a subscriber: ziaee.Tue, Mar 10, 10:54 PM

ziaee added inline comments.

graphics/egl-wayland2/Makefile
8	We shouldn't have it so that this doesn't come up for any variation of searching for nvidia. Suggest explaining what it is.

junchoon_dec.sakura.ne.jp added inline comments.Tue, Mar 10, 11:47 PM

graphics/egl-wayland2/Makefile
8	Your proposed fix is clearly worse because there's graphics/egl-wayland and make things confusing. Both are provided at NVIDIA github. Both graphics/egl-wayland and graphics/egl-wayland can be installed at the same time for NVIDIA drivers 560 and later (possible to drop graphics/egl-wayland after confirming no negative feedbacks), but x11/nvidia-driver-470 requires graphics/egl-wayland alone. My proposal to your comment is to keep this as-is for now as of consistency, and rewrite both as part of wordsmith works. I think it may be clearer for tracking commit logs. For the time of wordsmith'ing, this would be better in contrast with your proposal for graphics/egl-x11 (D55452): Dma-buf-based NVIDIA graphics Wayland EGL platform library And for graphics/egl-wayland, EGLStream-based NVIDIA graphics Wayland EGL platform library

kbowling accepted this revision.Wed, Mar 11, 12:14 AM

This revision is now accepted and ready to land.Wed, Mar 11, 12:14 AM

Closed by commit R11:b23b14c3bfc0: graphics/egl-wayland2: New port (authored by junchoon_dec.sakura.ne.jp, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyWed, Mar 11, 12:19 AM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: R11:b23b14c3bfc0: graphics/egl-wayland2: New port.

Agree that comment should reference NVIDIA but that is fine to do in a non-functional commit

ziaee added inline comments.Wed, Mar 11, 12:24 AM

graphics/egl-wayland2/Makefile
8	Your proposed fix is clearly worse It was just the first thing I could come up with being unfamiliar with it. My ask is just that this should be discoverable to people using pkg. My proposal to your comment is to keep this as-is for now as of consistency, and rewrite both as part of wordsmith works. I think it may be clearer for tracking commit logs. That sounds good. Let's ship this and then I'll update that review?