Page MenuHomeFreeBSD

Exclude options in slave ports that are implied by other default options.
ClosedPublic

Authored by bdrewery on Mar 3 2016, 5:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 1:13 AM
Unknown Object (File)
Feb 14 2024, 11:35 AM
Unknown Object (File)
Feb 11 2024, 1:58 AM
Unknown Object (File)
Feb 3 2024, 8:25 AM
Unknown Object (File)
Jan 30 2024, 6:55 AM
Unknown Object (File)
Dec 25 2023, 9:57 AM
Unknown Object (File)
Dec 25 2023, 9:57 AM
Unknown Object (File)
Dec 25 2023, 9:43 AM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP414547: Fix excluding implied options.
Summary
Test Plan

make -V OPTIONS_DEFAULT in devel/git-lite

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2757
Build 2778: arc lint + arc unit

Event Timeline

bdrewery retitled this revision from to Exclude options in slave ports that are implied by other default options..
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
bdrewery added a reviewer: portmgr.
bdrewery added a subscriber: garga.

I'm sure there's a reason, but couldn't something like this work:

.for opt in ${_ALL_EXCLUDE}
_ALL_EXCLUDE+= ${${opt}_IMPLIES}
.endfor
In D5538#118229, @mat wrote:

I'm sure there's a reason, but couldn't something like this work:

.for opt in ${_ALL_EXCLUDE}
_ALL_EXCLUDE+= ${${opt}_IMPLIES}
.endfor

I haven't tested but I think this would essentially try to expand a variable name with spaces: ${PERL GIT P4} rather than ${PERL} ${GIT} ${P4}.

This revision was automatically updated to reflect the committed changes.