Page MenuHomeFreeBSD

Exclude options in slave ports that are implied by other default options.
ClosedPublic

Authored by bdrewery on Mar 3 2016, 5:40 PM.

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP414547: Fix excluding implied options.
Summary
Test Plan

make -V OPTIONS_DEFAULT in devel/git-lite

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bdrewery updated this revision to Diff 14037.Mar 3 2016, 5:40 PM
bdrewery retitled this revision from to Exclude options in slave ports that are implied by other default options..
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
bdrewery added a reviewer: portmgr.
bdrewery added a subscriber: garga.
Herald added a subscriber: mat. · View Herald Transcript
mat added a comment.Mar 3 2016, 10:35 PM

I'm sure there's a reason, but couldn't something like this work:

.for opt in ${_ALL_EXCLUDE}
_ALL_EXCLUDE+= ${${opt}_IMPLIES}
.endfor
In D5538#118229, @mat wrote:

I'm sure there's a reason, but couldn't something like this work:

.for opt in ${_ALL_EXCLUDE}
_ALL_EXCLUDE+= ${${opt}_IMPLIES}
.endfor

I haven't tested but I think this would essentially try to expand a variable name with spaces: ${PERL GIT P4} rather than ${PERL} ${GIT} ${P4}.

This revision was automatically updated to reflect the committed changes.