nvmecontrol: Pass 1 to uint8_t arg
ClosedPublic
Actions

Authored by imp on Mon, Feb 2, 6:07 PM.

Details

Reviewers

chs
jhb

Commits

rGcbb7441245cf: nvmecontrol: Pass 1 to uint8_t arg

Summary

The rae arg is uint8_t (which we then shift over to the right bit. Pass
'1' instead of 'true' here to match the interface. While true is
promoted to (uint8_t)1, we don't use it as a bool in read_logpage().

Fixes: 5322eec86ae4 ("nvmecontrol: Always set the RAE bit on telemetry-log requests")
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Mon, Feb 2, 6:07 PM

Herald added a subscriber: dab. · View Herald TranscriptMon, Feb 2, 6:07 PM

imp requested review of this revision.Mon, Feb 2, 6:07 PM

Harbormaster completed remote builds in B70351: Diff 171013.Mon, Feb 2, 6:07 PM

imp added reviewers: chs, jhb.Mon, Feb 2, 6:08 PM

chs accepted this revision.Mon, Feb 2, 6:10 PM

This revision is now accepted and ready to land.Mon, Feb 2, 6:10 PM

Closed by commit rGcbb7441245cf: nvmecontrol: Pass 1 to uint8_t arg (authored by imp). · Explain WhyTue, Feb 3, 5:34 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGcbb7441245cf: nvmecontrol: Pass 1 to uint8_t arg.

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

telemetry.c

4 lines

Diff 171096

View Options

sbin/nvmecontrol/telemetry.c

nvmecontrol: Pass 1 to uint8_t argClosedPublicActions