ifinfo: Print names of CSUM bits
ClosedPublic
Actions

Authored by timo.voelker_fh-muenster.de on Feb 2 2026, 4:49 PM.

Details

Reviewers

wollman
tuexen

Commits

rGd84870d90baf: ifinfo: improve output of hwassist value

Summary

ifinfo prints the value of if_hwassist. The value is hard to read since it is a bitmap for CSUM_* bits defined in src/sys/sys/mbuf.h. With this patch, ifinfo additionally prints the names of the CSUM_* bits.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

timo.voelker_fh-muenster.de created this revision.Feb 2 2026, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2026, 4:49 PM

timo.voelker_fh-muenster.de requested review of this revision.Feb 2 2026, 4:49 PM

tuexen added inline comments.Feb 2 2026, 6:43 PM

tools/tools/ifinfo/ifinfo.c
199	`first` is used as a boolean. Can't you use `bool first` instead of `int first`?

timo.voelker_fh-muenster.de marked an inline comment as done.Feb 3 2026, 9:29 AM

timo.voelker_fh-muenster.de added inline comments.

tools/tools/ifinfo/ifinfo.c
199	`bool` seems not to be available as a data type when building a tool.

Use CSUM_BITS string defined in sys/mbuf.h for output.

Use bool type, which is possible after adding #include <ctype.h>

tuexen accepted this revision.Feb 3 2026, 2:22 PM

This revision is now accepted and ready to land.Feb 3 2026, 2:22 PM

Closed by commit rGd84870d90baf: ifinfo: improve output of hwassist value (authored by timo.voelker_fh-muenster.de, committed by tuexen). · Explain WhyFeb 8 2026, 8:06 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGd84870d90baf: ifinfo: improve output of hwassist value.

Revision Contents
Changeset List

Path

Size

tools/

ifinfo/

ifinfo.c

48 lines

Diff 171466

View Options

tools/tools/ifinfo/ifinfo.c

ifinfo: Print names of CSUM bitsClosedPublicActions