libc/tests: Clean up *dir() tests
ClosedPublic
Actions

Authored by des on Feb 2 2026, 4:09 PM.

Tags

None

Referenced Files

	F172912298: D55054.id.diff
	Tue, Sep 22, 1:17 AM

	F172904251: D55054.id170987.diff
	Mon, Sep 21, 11:50 PM

	Unknown Object (File)
	Wed, Sep 9, 12:39 AM

	Unknown Object (File)
	Sun, Sep 6, 5:39 AM

	Unknown Object (File)
	Sun, Sep 6, 12:57 AM

	Unknown Object (File)
	Sat, Sep 5, 2:52 PM

	Unknown Object (File)
	Fri, Sep 4, 5:07 PM

	Unknown Object (File)
	Fri, Sep 4, 7:02 AM

View All 86 Files

Subscribers

imp

Details

Reviewers

asomers
markj

Group Reviewers

Klara
tests

Commits

rG0018cfdb91c3: libc/tests: Clean up *dir() tests
rG27e73a1802a9: libc/tests: Clean up *dir() tests
rGd70b9eb74fc4: libc/tests: Clean up *dir() tests

Summary

Mainly, avoid reusing the name of one of the functions we should be
testing (but aren't) for local variables.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Feb 2 2026, 4:09 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2026, 4:09 PM

des requested review of this revision.Feb 2 2026, 4:09 PM

Harbormaster completed remote builds in B70345: Diff 170987.Feb 2 2026, 4:09 PM

des added reviewers: tests, asomers.Feb 3 2026, 1:46 PM

markj accepted this revision as: markj.Feb 3 2026, 2:20 PM

This revision is now accepted and ready to land.Feb 3 2026, 2:20 PM

Closed by commit rGd70b9eb74fc4: libc/tests: Clean up *dir() tests (authored by des). · Explain WhyFeb 3 2026, 2:40 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGd70b9eb74fc4: libc/tests: Clean up *dir() tests.

des added a commit: rG27e73a1802a9: libc/tests: Clean up *dir() tests.Feb 5 2026, 3:27 PM

des added a commit: rG0018cfdb91c3: libc/tests: Clean up *dir() tests.

Revision Contents
Changeset List

Path

Size

lib/

libc/

tests/

gen/

dir2_test.c

28 lines

Diff 171068

View Options

lib/libc/tests/gen/dir2_test.c

libc/tests: Clean up *dir() testsClosedPublicActions