Page MenuHomeFreeBSD
Differential D549

- Import lagg(4) broadcast mode from OpenBSD.
ClosedPublic
Actions

Authored by araujo on Aug 6 2014, 5:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 3:09 AM
Unknown Object (File)
Wed, Nov 13, 6:25 PM
Unknown Object (File)
Oct 20 2024, 7:30 AM
Unknown Object (File)
Oct 18 2024, 11:41 PM
Unknown Object (File)
Oct 1 2024, 10:41 PM
Unknown Object (File)
Sep 25 2024, 7:43 AM
Unknown Object (File)
Aug 31 2024, 2:54 PM
Unknown Object (File)
Aug 23 2024, 12:06 PM
View All 82 Files
Subscribers
None

Details

Reviewers
glebius
thompsa
adrian
Summary
  • Import the broadcast mode from OpenBSD, it allows sends frames to all ports of the

lagg(4) group and receives frames on any port of the lagg(4).

NOTE: Yes, its will send duplicated packages, but some applications might want use it in this way.
Test Plan
  • Verified using ifstat(1) and tcpdump(1).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

araujo updated this revision to Diff 977.Aug 6 2014, 5:10 AM
araujo retitled this revision from to - Import lagg(4) broadcast mode from OpenBSD..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added reviewers: thompsa, glebius, adrian.
araujo updated this object.Aug 6 2014, 6:40 AM
glebius edited edge metadata.Aug 8 2014, 10:41 AM

Patch should not hijack LAGG_PROTO_ETHERCHANNEL. Apart that it looks fine.

thompsa edited edge metadata.EditedAug 10 2014, 10:51 PM

I agree with Gleb. I have noted in D539 that LAGG_PROTO_ETHERCHANNEL should be kept for compatibility.

araujo added a comment.Sep 17 2014, 9:06 AM

Hello guys,

Finally I had time to finish this patch, as Glebius and Thompsa mention, this new patch does not hijack the FEC protocol, and we keep it as it is, just add a new protocol options 'broadcast'.

Looking forward for your review and approval.

Best Regards,

lagg.diff6 KBDownload

glebius added a comment.Sep 17 2014, 9:30 AM

Isn't it possible to drop new patch on top of old one in this review system?

araujo added a comment.Sep 17 2014, 9:38 AM

Maybe is possible to remove the old patch entirely and attache this one. I can try!

araujo updated this revision to Diff 1654.Sep 17 2014, 9:41 AM
araujo edited edge metadata.

Add the new patch that does not hijack the FEC protocol.

glebius accepted this revision.Sep 17 2014, 9:59 AM
glebius edited edge metadata.
This revision is now accepted and ready to land.Sep 17 2014, 9:59 AM
araujo closed this revision.Sep 18 2014, 3:12 AM

Committed at: http://svnweb.freebsd.org/base?view=revision&sortby=date&revision=271732

dim mentioned this in rGfa267a329ffa: Fix unused variable warning in if_lagg.c.Jul 21 2022, 7:07 PM
dim mentioned this in rG6cc991e810f3: Fix unused variable warning in if_lagg.c.Jul 24 2022, 11:03 AM
dim mentioned this in rG459bc065e29b: Fix unused variable warning in if_lagg.c.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
4 lines
share/
man/
man4/
4 lines
sys/
net/
8 lines
98 lines

Diff 1654

View Options

sbin/ifconfig/ifconfig.8

Loading...
View Options

share/man/man4/lagg.4

Loading...
View Options

sys/net/if_lagg.h

Loading...
View Options

sys/net/if_lagg.c

Loading...