Differential D54871
arm64: Fix SVE context alignment in signal frame Authored by wac_gmail.com on Sun, Jan 25, 9:16 AM. Tags None Referenced Files
Details Round up the SVE buffer size to 16 bytes. The SVE context size calculation could result in a value not divisible by 16 (or even 4), causing misalignment of subsequent context records in the signal frame. This violated the ABI and caused sigreturn(2) to fail with EINVAL when validating the alignment of the next context header. 16-byte alignment is chosen to satisfy the AArch64 stack alignment constraint. PR: 292177 Run triggering openssl test from 292177 (openssl speed -evp chacha20-poly1305) and observe it no longer crashes after this change.
Diff Detail
Event TimelineComment Actions At first glance https://reviews.freebsd.org/rGa9e77eb7016df70723c208fc09fbd01ec23a732d will fix this issue. I'll apply it to my copy of the tree and make sure it fixes the openssl crash since that's a nice repeatable crash case for the alignment issue. I should be able to get that done in the next day or two. Comment Actions I've confirmed that rGa9e77eb7016df70723c208fc09fbd01ec23a732d resolves the issue in PR 292177, so abandoning this change. |