Page MenuHomeFreeBSD
Differential D54861

LinuxKPI: pci: make sure a tailq and lock are initialized
ClosedPublic
Actions

Authored by bz on Sat, Jan 24, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 14, 4:18 PM
Unknown Object (File)
Fri, Feb 13, 2:43 PM
Unknown Object (File)
Wed, Feb 11, 10:49 AM
Unknown Object (File)
Tue, Feb 10, 6:30 PM
Unknown Object (File)
Mon, Feb 9, 11:11 PM
Unknown Object (File)
Mon, Feb 9, 6:27 AM
Unknown Object (File)
Sun, Feb 1, 1:49 AM
Unknown Object (File)
Tue, Jan 27, 3:40 PM
View All 14 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
dumbbell
Group Reviewers
linuxkpi
Commits
rG1f19fc2632c9: LinuxKPI: pci: make sure a tailq and lock are initialized
Summary

Move the initializations of the tailq, and lock from
linux_pci_attach_device() into lkpifill_pci_dev() so that they are
initialized in all cases we create a device (see all the possible
callers of lkpifill_pci_dev()).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

I hit one of these cases last year in December but I lost
track under which circumstances as the change was just
hanging along D.54841.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Sat, Jan 24, 10:20 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptSat, Jan 24, 10:20 PM
bz requested review of this revision.Sat, Jan 24, 10:20 PM
Harbormaster completed remote builds in B70117: Diff 170354.Sat, Jan 24, 10:20 PM
bz added inline comments.Sat, Jan 24, 10:34 PM
sys/compat/linuxkpi/common/src/linux_pci.c
388

The move of this line is unrelated to the change but it made sense to group them together below.

bz added a comment.Mon, Feb 9, 12:53 AM

Anyone time for the simple review?

emaste accepted this revision.Mon, Feb 9, 2:25 PM
This revision is now accepted and ready to land.Mon, Feb 9, 2:25 PM
dumbbell accepted this revision.Mon, Feb 9, 6:45 PM
Closed by commit rG1f19fc2632c9: LinuxKPI: pci: make sure a tailq and lock are initialized (authored by bz). · Explain WhyTue, Feb 10, 12:49 AM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG1f19fc2632c9: LinuxKPI: pci: make sure a tailq and lock are initialized.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
7 lines

Diff 171606

View Options

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...