Page MenuHomeFreeBSD
Differential D54669

exterr: Sort output from make_libc_exterr_cat_filenames.sh
ClosedPublic
Actions

Authored by markj on Mon, Jan 12, 5:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 28, 10:10 PM
Unknown Object (File)
Tue, Jan 27, 11:35 AM
Unknown Object (File)
Sun, Jan 25, 3:23 PM
Unknown Object (File)
Sun, Jan 25, 6:35 AM
Unknown Object (File)
Sat, Jan 24, 6:03 PM
Unknown Object (File)
Wed, Jan 21, 3:23 AM
Unknown Object (File)
Mon, Jan 19, 10:13 PM
Unknown Object (File)
Mon, Jan 19, 3:04 AM
View All 19 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG36daea2a6da0: exterr: Sort output from make_libc_exterr_cat_filenames.sh
rGbda6ed2ee4d8: exterr: Sort output from make_libc_exterr_cat_filenames.sh
Summary

Otherwise the script may permute the order of entries in the file since
find(1) output is not stable.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jan 12, 5:54 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 12, 5:54 PM
markj requested review of this revision.Mon, Jan 12, 5:54 PM
Harbormaster completed remote builds in B69827: Diff 169530.Wed, Jan 14, 12:50 AM
kib added a comment.Wed, Jan 14, 4:03 PM

I also noted it, but used find | sort in D54592.

Feel free to commit. I think you want to split the commit of script and the commit of the regenerated file, to be able to MFC without conflicts.

kib accepted this revision.Wed, Jan 14, 4:03 PM
This revision is now accepted and ready to land.Wed, Jan 14, 4:03 PM
Closed by commit rGbda6ed2ee4d8: exterr: Sort output from make_libc_exterr_cat_filenames.sh (authored by markj). · Explain WhyFri, Jan 16, 3:59 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGbda6ed2ee4d8: exterr: Sort output from make_libc_exterr_cat_filenames.sh.
markj added a commit: rG36daea2a6da0: exterr: Sort output from make_libc_exterr_cat_filenames.sh.Mon, Jan 26, 12:53 AM

Revision Contents
Changeset List

PathSize
tools/
build/
2 lines

Diff 169850

View Options

tools/build/make_libc_exterr_cat_filenames.sh

Loading...