Page MenuHomeFreeBSD
Differential D54630

mrsas(4): Drop 'FreeBSD' in version banner
AbandonedPublic
Actions

Authored by michaelo on Fri, Jan 9, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 10, 9:48 AM
Unknown Object (File)
Sat, Jan 10, 5:39 AM
Unknown Object (File)
Sat, Jan 10, 3:59 AM
Unknown Object (File)
Fri, Jan 9, 10:12 PM
Subscribers
None

Details

Reviewers
ziaee
imp
emaste
Summary

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69774
Build 66657: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Fri, Jan 9, 9:34 PM
michaelo created this revision.
michaelo mentioned this in D54519: mfi(4)/mrsas(4): Print driver versions consistently.Fri, Jan 9, 9:34 PM
Harbormaster completed remote builds in B69774: Diff 169418.Fri, Jan 9, 9:35 PM
michaelo edited the summary of this revision. (Show Details)Fri, Jan 9, 9:35 PM
emaste added inline comments.Fri, Jan 9, 9:42 PM
sys/dev/mrsas/mrsas.c
357

Why don't we make this device_printf like mfi and then we don't need the driver name in the text?

michaelo added inline comments.Fri, Jan 9, 9:45 PM
sys/dev/mrsas/mrsas.c
357

That would be ideal, but I didn't do it becuase I didn't want to chane how mrsas_probe() behaves.

ziaee added a comment.Fri, Jan 9, 9:50 PM

If the point is to align the two driver strings, I think that's one logical change and could/should be one commit.

michaelo abandoned this revision.Fri, Jan 9, 10:07 PM

Merged into D54519

Revision Contents
Changeset List

PathSize
sys/
dev/
mrsas/
2 lines

Diff 169418

View Options

sys/dev/mrsas/mrsas.c

Loading...