Page MenuHomeFreeBSD
Differential D54620

ads111x: Convert driver to CTLFLAG_MPSAFE
ClosedPublic
Actions

Authored by guest-seuros on Fri, Jan 9, 3:53 PM.
Tags
None
Referenced Files
F141887679: D54620.diff
Mon, Jan 12, 12:55 AM
Unknown Object (File)
Sat, Jan 10, 5:41 AM
Unknown Object (File)
Sat, Jan 10, 1:28 AM
Unknown Object (File)
Sat, Jan 10, 12:58 AM
Unknown Object (File)
Fri, Jan 9, 10:10 PM
Unknown Object (File)
Fri, Jan 9, 9:39 PM
Unknown Object (File)
Fri, Jan 9, 8:48 PM
Subscribers
None

Details

Reviewers
jhb
imp
markj
Commits
rG2c029cff5ba3: ads111x: Convert driver to CTLFLAG_MPSAFE
Summary

Replace CTLFLAG_NEEDGIANT with CTLFLAG_MPSAFE for all ADC sensor
sysctls. The driver uses I2C bus transfers which handle locking
internally via the I2C bus layer.

Sysctls converted:

  • dev.ads111x.X.channelN.gain_index (PGA setting)
  • dev.ads111x.X.channelN.rate_index (sample rate)
  • dev.ads111x.X.channelN.voltage (sampled voltage)
  • dev.ads111x.X.config (configuration register)
  • dev.ads111x.X.lo_thresh (comparator low threshold)
  • dev.ads111x.X.hi_thresh (comparator high threshold)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

guest-seuros created this revision.Fri, Jan 9, 3:53 PM
guest-seuros held this revision as a draft.
Harbormaster completed remote builds in B69755: Diff 169391.Fri, Jan 9, 3:53 PM
guest-seuros published this revision for review.Fri, Jan 9, 3:58 PM
markj accepted this revision.Mon, Jan 12, 12:50 AM

The driver uses I2C bus transfers which handle locking internally via the I2C bus layer.

Well, really it serializes all of the sysctl handlers using an internal lock.

This revision is now accepted and ready to land.Mon, Jan 12, 12:50 AM
Closed by commit rG2c029cff5ba3: ads111x: Convert driver to CTLFLAG_MPSAFE (authored by guest-seuros, committed by markj). · Explain WhyMon, Jan 12, 12:58 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG2c029cff5ba3: ads111x: Convert driver to CTLFLAG_MPSAFE.

Revision Contents
Changeset List

PathSize
sys/
dev/
iicbus/
adc/
12 lines

Diff 169496

View Options

sys/dev/iicbus/adc/ads111x.c

Loading...