Page MenuHomeFreeBSD
Differential D54618

jme: Convert driver to CTLFLAG_MPSAFE
Needs ReviewPublic
Actions

Authored by guest-seuros on Fri, Jan 9, 3:40 PM.
Tags
None
Referenced Files
F141863134: D54618.diff
Sun, Jan 11, 3:09 PM
F141859714: D54618.diff
Sun, Jan 11, 1:46 PM
F141817669: D54618.diff
Sat, Jan 10, 8:35 PM
Unknown Object (File)
Sat, Jan 10, 1:29 AM
Subscribers
None

Details

Reviewers
jhb
imp
markj
Summary

Replace CTLFLAG_NEEDGIANT with CTLFLAG_MPSAFE for all interrupt
coalescing sysctls. The driver uses jme_mtx mutex for proper
synchronization and does not require Giant lock.

Sysctls converted:

  • dev.jme.X.tx_coal_to (TX coalescing timeout)
  • dev.jme.X.tx_coal_pkt (TX coalescing packet count)
  • dev.jme.X.rx_coal_to (RX coalescing timeout)
  • dev.jme.X.rx_coal_pkt (RX coalescing packet count)
  • dev.jme.X.process_limit (max RX events to process)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

guest-seuros requested review of this revision.Fri, Jan 9, 3:40 PM
guest-seuros created this revision.
Harbormaster completed remote builds in B69754: Diff 169389.Fri, Jan 9, 3:40 PM
guest-seuros updated this revision to Diff 169445.Sat, Jan 10, 10:32 AM

speaker, clock: Replace Giant lock with fine-grained locking

Add sx lock to the speaker driver to protect spkr_active and spkr_inbuf,
removing the D_NEEDGIANT flag. Add mtx_lock_spin protection for timer2_state
in clock.c timer_spkr_acquire/release functions.

Harbormaster completed remote builds in B69781: Diff 169445.Sat, Jan 10, 10:32 AM
guest-seuros updated this revision to Diff 169447.Sat, Jan 10, 10:37 AM

Sorry, still using arc incorrectly. Need i need to learn git-arc.

Revision Contents
Changeset List

PathSize
sys/
dev/
jme/
10 lines

Diff 169447

View Options

sys/dev/jme/if_jme.c

Loading...