Remove platform_mp_init_secondary as it's unneeded.
ClosedPublic
Actions

Authored by andrew on Feb 26 2016, 11:00 AM.

Details

Reviewers

imp
• ian

Group Reviewers

ARM

Commits

rS296100: Almost all copies of platform_mp_init_secondary just called

Summary

Almost all copies of platform_mp_init_secondary just called
intr_pic_init_secondary. Replace them with a direct call. On bcm2836
and Armada XP we need to add this function, but it can be empty.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew updated this revision to Diff 13769.Feb 26 2016, 11:00 AM

andrew retitled this revision from to Remove platform_mp_init_secondary as it's unneeded..

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added a reviewer: ARM.

Herald added a subscriber: imp. · View Herald TranscriptFeb 26 2016, 11:00 AM

Only define intr_pic_init_secondary on bcm283x when building for SMP

skra added a subscriber: skra.Feb 26 2016, 11:35 AM

skra added inline comments.

sys/arm/arm/mp_machdep.c
237 ↗	(On Diff #13770)	I'm okay with it if the change means that all possible secondary inits should go to init_secondary() directly. As some of them may even be called on different places in the function.

andrew added inline comments.Feb 26 2016, 12:02 PM

sys/arm/arm/mp_machdep.c
237 ↗	(On Diff #13770)	If a given SoC has a custom requirement we should use the `PLATFORM` code to handle it. I'm currently working on updating it to support SMP and found, across all SoCs that currently use it, we only need two of the `platform_mp_*` functions, one to count the CPUs, and one to start them. The other cases can be handled with a default function, suggesting we should just remove it.