Page MenuHomeFreeBSD

Rip off IPI part from intrng.
ClosedPublic

Authored by skra on Feb 26 2016, 10:56 AM.
Referenced Files
Unknown Object (File)
Fri, Apr 4, 10:10 AM
Unknown Object (File)
Mar 10 2025, 1:57 AM
Unknown Object (File)
Feb 8 2025, 1:21 PM
Unknown Object (File)
Dec 7 2024, 2:38 AM
Unknown Object (File)
Sep 29 2024, 11:24 PM
Unknown Object (File)
Sep 24 2024, 3:11 PM
Unknown Object (File)
Sep 16 2024, 10:38 PM
Unknown Object (File)
Aug 10 2024, 2:12 AM
Subscribers
None

Details

Summary

Once when ARM intrng is used for mips too, there was a call to rip off IPI part from it. So this is done here.

The intrcnt[] and intrnames[] related part is left for IPI in intrng, thus isrc_setup_ipi_counters() and isrc_increment_ipi_count() are global now. However, when it comes, it's optional to use it. The place in counters is reserved only when INTR_IPI_COUNT is defined.

Note that I expect that more changes will follow in intrng.

Test Plan

Tested on ARM only.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

skra retitled this revision from to Rip off IPI part from intrng..
skra updated this object.
skra edited the test plan for this revision. (Show Details)
skra added reviewers: andrew, ian, imp, kan.
skra set the repository for this revision to rS FreeBSD src repository - subversion.
skra added projects: ARM, MIPS.
imp edited edge metadata.

This looks like just code motion, though if there's other subtle changes they are lost on me.

The commit message is a bit confusing. Rather than using "rip off" stuff, maybe something like

"move parts of intng that were really arm specific back into arm files in anticipation of intng being used on mips"

sys/kern/subr_intr.c
124 ↗(On Diff #13768)

Strictly speaking, this is a nop change... Logically, I think the old code makes more sense.

This revision is now accepted and ready to land.Feb 26 2016, 3:44 PM
This revision was automatically updated to reflect the committed changes.