Differential D54584

makefs: Fix atime tests on MS-DOS (FAT) file systems
AcceptedPublic
Actions

Authored by jlduran on Wed, Jan 7, 7:54 PM.

Details

Reviewers

ngie

Group Reviewers

tests

Summary

On FAT file systems, access time has a resolution of 1 day, so it is
really the access date.

Strip the time component from the epoch timestamp in order to check the
access time.

Reference: https://learn.microsoft.com/en-us/windows/win32/sysinfo/file-times

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69696
Build 66579: arc lint + arc unit

Event Timeline

jlduran created this revision.Wed, Jan 7, 7:54 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jan 7, 7:54 PM

jlduran requested review of this revision.Wed, Jan 7, 7:54 PM

Harbormaster completed remote builds in B69696: Diff 169267.Wed, Jan 7, 7:54 PM

jlduran added a child revision: D54585: makefs: Define HAVE_STRUCT_STAT_{BIRTHTIME,_ST_MTIMENSEC}.Wed, Jan 7, 7:55 PM

jlduran added a reviewer: tests.Wed, Jan 7, 7:55 PM

jlduran mentioned this in D54585: makefs: Define HAVE_STRUCT_STAT_{BIRTHTIME,_ST_MTIMENSEC}.Thu, Jan 8, 4:50 AM

ngie accepted this revision.Sun, Jan 11, 4:12 AM

This revision is now accepted and ready to land.Sun, Jan 11, 4:12 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

makefs/

tests/

makefs_msdos_tests.sh

16 lines

Diff 169267

View Options

usr.sbin/makefs/tests/makefs_msdos_tests.sh

makefs: Fix atime tests on MS-DOS (FAT) file systemsAcceptedPublicActions