Page MenuHomeFreeBSD

mrsas.4: Synchronize with CURRENT
AbandonedPublic

Authored by michaelo on Wed, Jan 7, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 12, 9:59 AM
Unknown Object (File)
Mon, Jan 12, 9:59 AM
Unknown Object (File)
Sat, Jan 10, 8:09 AM
Unknown Object (File)
Sat, Jan 10, 5:32 AM
Unknown Object (File)
Fri, Jan 9, 11:26 PM
Unknown Object (File)
Fri, Jan 9, 7:56 PM
Unknown Object (File)
Wed, Jan 7, 7:35 PM
Unknown Object (File)
Wed, Jan 7, 1:41 PM
Subscribers

Details

Reviewers
ziaee
Summary

This is a logical backport of the manpage since the driver is
logically identical.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69677
Build 66560: arc lint + arc unit

Event Timeline

No function change, diffed the driver between CURRENT and stable/1{3,4} and they are identical, but the manpage updates have never been cherry-picked.

We don't really do it this way. If you want to sync this manual with current, you MFC the changes. It's a lot easier then to keep track of everything, and not have merge conflicts.

This is mostly my commit, I will MFC it, then you should be able to MFC yours without conflict

ziaee requested changes to this revision.Wed, Jan 7, 1:56 PM

I finished MFCing my end. Now, you should wait two days minimum, and then if nobody complains, you switch to the stable branches and git cherry-pick -x ccec94bf63d. This is written in the comitters guide.

This revision now requires changes to proceed.Wed, Jan 7, 1:56 PM

Also, in your last commit to stable/13, you violated two rules:

  1. Commit messages are wrapped at 72 characters.
  2. MFC after 3 days means "wait three days to see if anything explodes for anyone before backporting". Unless there is some particular emergency, do not do this. Especially to a legacy support branch. Legacy support branch needs to not break, it doesn't need new features.

Thank you for your attention to these details.

Also, in your last commit to stable/13, you violated two rules:

  1. Commit messages are wrapped at 72 characters.

72, not 80? Will check commiter's handbook again.

  1. MFC after 3 days means "wait three days to see if anything explodes for anyone before backporting". Unless there is some particular emergency, do not do this. Especially to a legacy support branch. Legacy support branch needs to not break, it doesn't need new features.

Yes, I am aware af that. I am sorry, I noticed this after I have perfomed the picks. I was too overzealous and will not work at late hours.

Thank you for your attention to these details.

Absolutely justified. Thank you for bringing up.

@ziaee, thank you very much for the backports. This perfect now.