Page MenuHomeFreeBSD

netinet: Use ICMP_REDIRECT_DEFAULT_TIMEOUT for redirtimeout and clarify sysctl description
AbandonedPublic

Authored by amy.vargas_netapp.com on Mon, Jan 5, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 10, 4:36 PM
Unknown Object (File)
Sat, Jan 10, 8:07 AM
Unknown Object (File)
Sat, Jan 10, 4:59 AM
Unknown Object (File)
Fri, Jan 9, 7:08 PM
Unknown Object (File)
Fri, Jan 9, 6:55 PM
Unknown Object (File)
Wed, Jan 7, 7:32 AM
Unknown Object (File)
Tue, Jan 6, 6:35 PM
Unknown Object (File)
Tue, Jan 6, 4:36 AM

Details

Reviewers
glebius
Group Reviewers
NetApp
network
Klara
Summary

Replace the hardcoded default value for the ICMP redirect route timeout sysctl (redirtimeout) with the ICMP_REDIRECT_DEFAULT_TIMEOUT macro for improved maintainability. Also, clarify the sysctl description to explicitly refer to "ICMP redirect route" instead of "redirect route".

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

glebius requested changes to this revision.Mon, Jan 5, 8:22 PM

But where is the ICMP_REDIRECT_DEFAULT_TIMEOUT defined? The patch as is can't be compilable.

This revision now requires changes to proceed.Mon, Jan 5, 8:22 PM

We are still working out some kinks on our end end to ensure this does not happen again. Once that is all resolved, I will resubmit under a new differential that has all the appropriate changes.