powerpc: put the isync inside the TD_LOCK() checking loop
ClosedPublic
Actions

Authored by adrian on Sat, Jan 3, 10:54 PM.

Details

Reviewers

Group Reviewers

Commits

rGa50789d8b89b: powerpc: put the isync inside the TD_LOCK() checking loop
rG8df2e5421468: powerpc: put the isync inside the TD_LOCK() checking loop

Summary

Fix a narrow window where the lock is unlocked but the checking CPU
hasn't flushed things appropriately.

I've seen this reliably trigger in qemu-system-ppc64 running power9 pseries
guests.

PR: kern/292167

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Sat, Jan 3, 10:54 PM

Herald added subscribers: jhibbits, imp. · View Herald TranscriptSat, Jan 3, 10:54 PM

adrian requested review of this revision.Sat, Jan 3, 10:54 PM

Harbormaster completed remote builds in B69595: Diff 168977.Sat, Jan 3, 10:55 PM

adrian planned changes to this revision.Sat, Jan 3, 10:55 PM

adrian added a reviewer: PowerPC.

do 32 bit as well, thanks jhibbits

Harbormaster completed remote builds in B69596: Diff 168979.Sat, Jan 3, 11:32 PM

adrian added a reviewer: jhibbits.Sat, Jan 3, 11:33 PM

jhibbits accepted this revision.Sat, Jan 3, 11:44 PM

This revision is now accepted and ready to land.Sat, Jan 3, 11:44 PM

Closed by commit rG8df2e5421468: powerpc: put the isync inside the TD_LOCK() checking loop (authored by adrian). · Explain WhySun, Jan 4, 2:28 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG8df2e5421468: powerpc: put the isync inside the TD_LOCK() checking loop.

adrian added a commit: rGa50789d8b89b: powerpc: put the isync inside the TD_LOCK() checking loop.Sun, Jan 11, 7:24 PM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

swtch32.S

2 lines

swtch64.S

2 lines

Diff 168981

View Options

sys/powerpc/powerpc/swtch32.S