Page MenuHomeFreeBSD
Differential D54478

powerpc: put the isync inside the TD_LOCK() checking loop
ClosedPublic
Actions

Authored by adrian on Jan 3 2026, 10:54 PM.
Tags
None
Referenced Files
F157197044: D54478.id168977.diff
Tue, May 19, 6:12 AM
Unknown Object (File)
Thu, May 14, 10:33 AM
Unknown Object (File)
Thu, May 14, 9:23 AM
Unknown Object (File)
Thu, May 14, 3:44 AM
Unknown Object (File)
Wed, May 13, 7:38 PM
Unknown Object (File)
Wed, May 13, 7:38 PM
Unknown Object (File)
Wed, May 13, 5:01 PM
Unknown Object (File)
Mon, May 11, 8:51 PM
View All 50 Files
Subscribers
imp
jhibbits

Details

Reviewers
jhibbits
Group Reviewers
PowerPC
Commits
rG666599639cf6: powerpc: put the isync inside the TD_LOCK() checking loop
rGa50789d8b89b: powerpc: put the isync inside the TD_LOCK() checking loop
rG8df2e5421468: powerpc: put the isync inside the TD_LOCK() checking loop
Summary

Fix a narrow window where the lock is unlocked but the checking CPU
hasn't flushed things appropriately.

I've seen this reliably trigger in qemu-system-ppc64 running power9 pseries
guests.

PR: kern/292167

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69596
Build 66479: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 3 2026, 10:54 PM
Herald added subscribers: jhibbits, imp. · View Herald TranscriptJan 3 2026, 10:54 PM
adrian requested review of this revision.Jan 3 2026, 10:54 PM
Harbormaster completed remote builds in B69595: Diff 168977.Jan 3 2026, 10:55 PM
adrian planned changes to this revision.Jan 3 2026, 10:55 PM
adrian added a reviewer: PowerPC.
adrian updated this revision to Diff 168979.Jan 3 2026, 11:32 PM

do 32 bit as well, thanks jhibbits

Harbormaster completed remote builds in B69596: Diff 168979.Jan 3 2026, 11:32 PM
adrian added a reviewer: jhibbits.Jan 3 2026, 11:33 PM
jhibbits accepted this revision.Jan 3 2026, 11:44 PM
This revision is now accepted and ready to land.Jan 3 2026, 11:44 PM
Closed by commit rG8df2e5421468: powerpc: put the isync inside the TD_LOCK() checking loop (authored by adrian). · Explain WhyJan 4 2026, 2:28 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG8df2e5421468: powerpc: put the isync inside the TD_LOCK() checking loop.
adrian added a commit: rGa50789d8b89b: powerpc: put the isync inside the TD_LOCK() checking loop.Jan 11 2026, 7:24 PM
adrian added a commit: rG666599639cf6: powerpc: put the isync inside the TD_LOCK() checking loop.Jan 30 2026, 5:07 AM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
powerpc/
2 lines
2 lines

Diff 168979

View Options

sys/powerpc/powerpc/swtch32.S

Loading...
View Options

sys/powerpc/powerpc/swtch64.S

Loading...