Page MenuHomeFreeBSD
Differential D54393

geom_part: Fix format string issues
ClosedPublic
Actions

Authored by des on Mon, Dec 29, 11:59 AM.
Tags
None
Referenced Files
F141014641: D54393.id168700.diff
Tue, Dec 30, 6:48 PM
F140979246: D54393.id.diff
Tue, Dec 30, 8:49 AM
F140976894: D54393.diff
Tue, Dec 30, 8:07 AM
Unknown Object (File)
Mon, Dec 29, 2:24 PM
Subscribers
imp

Details

Reviewers
asomers
js
Commits
rGfaff7013187b: geom_part: Fix format string issues
Summary

This fixes a segfault on i386 and armv7 and numerous style violations.

PR: 292008
Fixes: 4f809ffec69c ("gpart: add libxo support for "show" subcommand + man page updates")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Mon, Dec 29, 11:59 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Dec 29, 11:59 AM
des requested review of this revision.Mon, Dec 29, 11:59 AM
Harbormaster completed remote builds in B69499: Diff 168692.Mon, Dec 29, 11:59 AM
js accepted this revision.Mon, Dec 29, 12:05 PM

LGTM, thanks for fixing this!

You should be able to tag https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292008 as fixed by this PR.

This revision is now accepted and ready to land.Mon, Dec 29, 12:05 PM
js added a comment.Mon, Dec 29, 12:05 PM

Ah, you already did

Closed by commit rGfaff7013187b: geom_part: Fix format string issues (authored by des). · Explain WhyMon, Dec 29, 1:22 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGfaff7013187b: geom_part: Fix format string issues.

Revision Contents
Changeset List

PathSize
lib/
geom/
part/
69 lines

Diff 168700

View Options

lib/geom/part/geom_part.c

Loading...