to SYSINCS
ClosedPublic
Actions

Authored by guest-ayrton on Sun, Dec 28, 7:51 PM.

Details

Reviewers

kevans
dim

Commits

rGb354a138c0cb: cross-build: Avoid adding <sys/cdefs.h> to SYSINCS
rG9ea1aadfdb30: cross-build: Avoid adding <sys/cdefs.h> to SYSINCS
rG248f879133bf: cross-build: Avoid adding <sys/cdefs.h> to SYSINCS
rGb6672803a1cf: cross-build: Avoid adding <sys/cdefs.h> to SYSINCS

Summary

The sys/cdefs.h in src is incompatible with glibc's sys/cdefs.h so
cross-building broke when the former was added to SYSINCS in 1c9ff80f06. This
commit adds a guard around that to only do that when building on FreeBSD. This
should fix github CI.

Test Plan

Ran buildkernel using tools/build/make.py on linux in github CI and
locally on FreeBSD to double check nothing broke.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-ayrton created this revision.Sun, Dec 28, 7:51 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Dec 28, 7:51 PM

guest-ayrton requested review of this revision.Sun, Dec 28, 7:51 PM

Harbormaster completed remote builds in B69491: Diff 168664.Sun, Dec 28, 7:51 PM

dim requested changes to this revision.Sun, Dec 28, 8:04 PM

dim added inline comments.

tools/build/Makefile
358	Note that I added `_visible.h` as a dependency of `cdefs.h`, so it would be better to put the whole block inside the `.if`, including the "Needed to build" comment.