Page MenuHomeFreeBSD
Differential D5429

address pr 202971: portsnap(8): manpage should reference pkg-version(1), not portversion(1)
ClosedPublic
Actions

Authored by jgh on Feb 25 2016, 12:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 24, 2:08 AM
Unknown Object (File)
Fri, Oct 24, 1:16 AM
Unknown Object (File)
Thu, Oct 23, 4:38 AM
Unknown Object (File)
Wed, Oct 22, 7:05 PM
Unknown Object (File)
Wed, Oct 22, 7:05 PM
Unknown Object (File)
Wed, Oct 22, 7:05 PM
Unknown Object (File)
Wed, Oct 22, 7:05 PM
Unknown Object (File)
Wed, Oct 22, 7:05 PM
View All Files
Subscribers
bdrewery
wblock

Details

Reviewers
wblock
bdrewery
Commits
rS296639: MFC 296280:
rS296638: MFC 296280:
rS296280: - update portsnap(8) to direct users to pkg-version
Summary

202971

update porstsnap man page

MFC after 1 week

Test Plan

mandoc -Tlint (clean)
man render (clean)

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 2638
Build 2656: Jenkins Build DocJenkins

Event Timeline

jgh updated this revision to Diff 13703.Feb 25 2016, 12:44 AM
jgh retitled this revision from to address pr 202971.
jgh updated this object.
jgh edited the test plan for this revision. (Show Details)
jgh added reviewers: bcr, remko, wblock.
jgh set the repository for this revision to rD FreeBSD doc repository - subversion.
jgh updated this object.
wblock retitled this revision from address pr 202971 to address pr 202971: portsnap(8): manpage should reference pkg-version(1), not portversion(1).Feb 25 2016, 3:04 AM
wblock edited edge metadata.

Please put the title of the bug in the title of the review. All the numbers look the same otherwise.

wblock added a comment.Feb 26 2016, 2:16 PM

.Xr pkg-version should be added to the See Also section, too. And since it is from ports and might not be present, .Xr pkg 7 should also be added there. (I think pkg(7) is the base system one of the same name as the one installed from ports.)

jgh updated this revision to Diff 13798.Feb 26 2016, 4:32 PM
jgh edited edge metadata.

address feedback

jgh removed reviewers: wblock, remko, bcr.Feb 26 2016, 4:59 PM
bdrewery requested changes to this revision.Feb 26 2016, 9:17 PM
bdrewery added a reviewer: bdrewery.
bdrewery added a subscriber: bdrewery.
bdrewery added inline comments.
usr.sbin/portsnap/portsnap/portsnap.8
275–276

missing commas

This revision now requires changes to proceed.Feb 26 2016, 9:17 PM
jgh updated this revision to Diff 13811.Feb 26 2016, 9:26 PM
jgh edited edge metadata.

address feedback, good catch.

jgh added a comment.Feb 28 2016, 9:04 PM

ping? how does this look?

wblock accepted this revision.Mar 1 2016, 9:01 PM
wblock added a reviewer: wblock.
wblock added a subscriber: wblock.

Looks okay from here, but there is no context for full checking. Please check with igor and mandoc before commit. Thanks!

Closed by commit rS296280: - update portsnap(8) to direct users to pkg-version (authored by jgh). · Explain WhyMar 1 2016, 10:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
portsnap/
portsnap/
4 lines

Diff 13703

View Options

usr.sbin/portsnap/portsnap/portsnap.8

Loading...