Page MenuHomeFreeBSD

sound: Improve snd_midi->{in,out}q allocation
AcceptedPublic

Authored by christos on Mon, Dec 8, 5:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 28, 5:55 AM
Unknown Object (File)
Thu, Dec 25, 8:46 PM
Unknown Object (File)
Tue, Dec 23, 1:36 AM
Unknown Object (File)
Thu, Dec 18, 9:48 PM
Unknown Object (File)
Thu, Dec 18, 7:30 AM
Unknown Object (File)
Mon, Dec 15, 7:18 PM
Unknown Object (File)
Mon, Dec 15, 2:44 PM
Unknown Object (File)
Mon, Dec 15, 10:33 AM
Subscribers

Details

Reviewers
markj
emaste
Summary

Currently we lock and allocate the buffers with M_NOWAIT, without
checking if the return value of malloc(). This is not necessary as
subsequent check below will eventually check that. However, for
correctness, allocate the buffers with M_WAITOK (there is no reason not
to) and lock afterwards.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69129
Build 66012: arc lint + arc unit