Differential D54131

sound: Improve snd_midi->{in,out}q allocation
ClosedPublic
Actions

Authored by christos on Dec 8 2025, 5:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 27, 7:05 AM

	Unknown Object (File)
	Wed, Aug 26, 1:06 PM

	Unknown Object (File)
	Tue, Aug 25, 3:43 PM

	Unknown Object (File)
	Tue, Aug 25, 8:16 AM

	Unknown Object (File)
	Tue, Aug 25, 7:27 AM

	Unknown Object (File)
	Tue, Aug 25, 6:57 AM

	Unknown Object (File)
	Fri, Aug 21, 10:09 PM

	Unknown Object (File)
	Wed, Aug 19, 5:12 PM

View All 64 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rG0ed90f4379c4: sound: Improve snd_midi->{in,out}q allocation
rGb9db6c212873: sound: Improve snd_midi->{in,out}q allocation

Summary

Currently we lock and allocate the buffers with M_NOWAIT, without
checking if the return value of malloc(). This is not necessary as
subsequent check below will eventually check that. However, for
correctness, allocate the buffers with M_WAITOK (there is no reason not
to) and lock afterwards.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Dec 8 2025, 5:13 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2025, 5:13 PM

christos requested review of this revision.Dec 8 2025, 5:13 PM

Harbormaster completed remote builds in B69129: Diff 167722.Dec 8 2025, 5:13 PM

christos mentioned this in D54129: sound: Retire snd_midi->qlock.Dec 11 2025, 11:37 AM

markj accepted this revision.Dec 14 2025, 4:16 PM

markj added inline comments.

sys/dev/sound/midi/midi.c
128	Why did you add M_ZERO?

This revision is now accepted and ready to land.Dec 14 2025, 4:16 PM

Closed by commit rGb9db6c212873: sound: Improve snd_midi->{in,out}q allocation (authored by christos). · Explain WhyJan 2 2026, 4:59 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGb9db6c212873: sound: Improve snd_midi->{in,out}q allocation.

christos added a commit: rG0ed90f4379c4: sound: Improve snd_midi->{in,out}q allocation.Jan 9 2026, 11:28 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

midi/

24 lines

Diff 168888

sys/dev/sound/midi/midi.c

Loading...