Page MenuHomeFreeBSD

kyua: Add flaky metadata
Needs RevisionPublic

Authored by igoro on Dec 6 2025, 6:40 PM.
Tags
None
Referenced Files
F166543721: D54105.id167973.diff
Fri, Aug 14, 6:17 AM
Unknown Object (File)
Thu, Aug 13, 1:31 AM
Unknown Object (File)
Thu, Aug 13, 12:00 AM
Unknown Object (File)
Wed, Aug 12, 12:26 AM
Unknown Object (File)
Tue, Aug 11, 6:03 AM
Unknown Object (File)
Mon, Aug 10, 11:55 AM
Unknown Object (File)
Mon, Aug 10, 11:29 AM
Unknown Object (File)
Sun, Aug 9, 7:36 PM
Subscribers

Details

Reviewers
kp
ngie
Group Reviewers
tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69236
Build 66119: arc lint + arc unit

Event Timeline

igoro requested review of this revision.Dec 6 2025, 6:40 PM
contrib/kyua/engine/flaky/tracker.cpp
52

Dumb question: isn't oneofn() just a specific version of xofy()?

contrib/kyua/engine/flaky/tracker.cpp
52

I expected you would catch it :) Yes, it's just 1/n. I've got the same idea after adding xofy. It's just too clumsy to add/remove a class or something in kyua, I would drop a thing only after some discussion and common decision made. Anyway, I would keep the general mechanism so that it's much easier to add a new tracker -- it follows kyua's design and really makes someone's life easier.

I guess the only pros to keep oneofn is the simplest specification with a single integer, but, probably, explicit "1/<integer>" specification is self-explainable. Because of that I would vote to eventually drop oneofn.

ngie requested changes to this revision.EditedDec 26 2025, 6:34 PM

Please provide an example (spec) of what you're implementing in the Testplan section.

This revision now requires changes to proceed.Dec 26 2025, 6:34 PM