Page MenuHomeFreeBSD

kyua: Add flaky metadata
Needs RevisionPublic

Authored by igoro on Sat, Dec 6, 6:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 26, 11:49 AM
Unknown Object (File)
Sat, Dec 20, 2:40 AM
Unknown Object (File)
Fri, Dec 19, 8:14 PM
Unknown Object (File)
Thu, Dec 18, 5:06 PM
Unknown Object (File)
Thu, Dec 18, 8:42 AM
Unknown Object (File)
Sun, Dec 14, 5:31 PM
Subscribers

Details

Reviewers
kp
ngie
Group Reviewers
tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69236
Build 66119: arc lint + arc unit

Event Timeline

igoro requested review of this revision.Sat, Dec 6, 6:40 PM
contrib/kyua/engine/flaky/tracker.cpp
52

Dumb question: isn't oneofn() just a specific version of xofy()?

contrib/kyua/engine/flaky/tracker.cpp
52

I expected you would catch it :) Yes, it's just 1/n. I've got the same idea after adding xofy. It's just too clumsy to add/remove a class or something in kyua, I would drop a thing only after some discussion and common decision made. Anyway, I would keep the general mechanism so that it's much easier to add a new tracker -- it follows kyua's design and really makes someone's life easier.

I guess the only pros to keep oneofn is the simplest specification with a single integer, but, probably, explicit "1/<integer>" specification is self-explainable. Because of that I would vote to eventually drop oneofn.

ngie requested changes to this revision.EditedFri, Dec 26, 6:34 PM

Please provide an example (spec) of what you're implementing in the Testplan section.

This revision now requires changes to proceed.Fri, Dec 26, 6:34 PM