Page MenuHomeFreeBSD

riscv/pmap: Handle superpages in pmap_extract_and_hold()
ClosedPublic

Authored by markj on Mon, Dec 1, 9:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 20, 9:27 PM
Unknown Object (File)
Fri, Dec 19, 3:37 PM
Unknown Object (File)
Fri, Dec 19, 1:01 AM
Unknown Object (File)
Thu, Dec 18, 11:30 PM
Unknown Object (File)
Tue, Dec 16, 8:37 AM
Unknown Object (File)
Tue, Dec 16, 5:48 AM
Unknown Object (File)
Mon, Dec 15, 7:10 PM
Unknown Object (File)
Sun, Dec 14, 10:18 PM
Subscribers

Details

Summary

Without this change, vm_fault_quick_hold_pages() falls back to the slow
fault handler() when it encounters a superpage mapping.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Mon, Dec 1, 9:53 PM

Return failure if the L2 entry is invalid

Fix handling of insufficient permissions.

markj added a reviewer: riscv.
This revision is now accepted and ready to land.Mon, Dec 1, 10:15 PM
sys/riscv/riscv/pmap.c
1142–1143

The l3p != NULL is now redundant.

1143–1155

This goto is redundant.

markj marked 2 inline comments as done.

Handle Alan's comments.

This revision now requires review to proceed.Tue, Dec 2, 5:34 PM
This revision is now accepted and ready to land.Tue, Dec 2, 5:36 PM
kib added inline comments.
sys/riscv/riscv/pmap.c
1159

Then this part could become just under 'else' and then goto is not needed at all.
But the current version is fine as well.

markj marked an inline comment as done.

Avoid gotos

This revision now requires review to proceed.Tue, Dec 2, 11:27 PM
This revision is now accepted and ready to land.Tue, Dec 2, 11:45 PM