ctfmerge: fix segfault when building on macOS
ClosedPublic
Actions

Authored by mp on Mon, Dec 1, 6:46 PM.

Details

Reviewers

markj
wosch
imp

Commits

rGf1b50f2cb0db: ctfmerge: fix segfault when building on macOS
rG2bf082df4931: ctfmerge: fix segfault when building on macOS
rG7cba27286364: ctfmerge: fix segfault when building on macOS
rG732b4aa05d78: ctfmerge: fix segfault when building on macOS

Summary

The barrier code was using semaphores which have been deprecated in
macOS and not working at all, causing a race condition. Since macOS
does not have pthread_barrier_*(), this change uses a condition
variable instead.

PR: 290958
Reported by: wosch
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mp created this revision.Mon, Dec 1, 6:46 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Dec 1, 6:46 PM

mp requested review of this revision.Mon, Dec 1, 6:46 PM

Harbormaster completed remote builds in B68967: Diff 167379.Mon, Dec 1, 6:46 PM

imp accepted this revision.Mon, Dec 1, 6:52 PM

This revision is now accepted and ready to land.Mon, Dec 1, 6:52 PM

markj accepted this revision.Mon, Dec 1, 7:24 PM

Closed by commit rG732b4aa05d78: ctfmerge: fix segfault when building on macOS (authored by mp). · Explain WhyMon, Dec 1, 8:53 PM

This revision was automatically updated to reflect the committed changes.

mp added a commit: rG732b4aa05d78: ctfmerge: fix segfault when building on macOS.

Why not just replace the entirety of barrier.[ch] with pthread_barrier(3)?

In D54018#1234971, @jrtc27 wrote:

Why not just replace the entirety of barrier.[ch] with pthread_barrier(3)?

I had the same thought, but apparently macOS doesn't implement it.

In D54018#1234972, @markj wrote:

In D54018#1234971, @jrtc27 wrote:

Why not just replace the entirety of barrier.[ch] with pthread_barrier(3)?

I had the same thought, but apparently macOS doesn't implement it.