Page MenuHomeFreeBSD
Differential D53908

libc: Simplify __get_locale()
ClosedPublic
Actions

Authored by des on Tue, Nov 25, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 8, 8:06 AM
Unknown Object (File)
Thu, Dec 4, 12:20 AM
Unknown Object (File)
Mon, Dec 1, 11:21 PM
Unknown Object (File)
Sun, Nov 30, 8:41 AM
Unknown Object (File)
Thu, Nov 27, 7:49 AM
Unknown Object (File)
Thu, Nov 27, 7:18 AM
Unknown Object (File)
Wed, Nov 26, 12:10 PM
Unknown Object (File)
Wed, Nov 26, 12:03 PM
View All 11 Files
Subscribers
imp

Details

Reviewers
kevans
fuz
Commits
rG8787b699b036: libc: Simplify __get_locale()
rG844f76c2426d: libc: Simplify __get_locale()
rG5af240c54bd2: libc: Simplify __get_locale()
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Tue, Nov 25, 7:54 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Nov 25, 7:54 PM
des requested review of this revision.Tue, Nov 25, 7:54 PM
Harbormaster completed remote builds in B68842: Diff 167095.Tue, Nov 25, 7:54 PM
des added a comment.EditedTue, Nov 25, 7:55 PM

The only explanation I can think of for why the code was the way it was is either:

  1. It just incrementally got that way and it didn't occur to anybody to rewrite it, or
  2. It actually matters for some deep branch prediction / speculative execution magic reasons

Can anyone shed some light on this?

Note that __has_thread_locale is global while __thread_locale is thread-local.

fuz added a comment.Tue, Nov 25, 8:02 PM

Looks reasonable. Should do the same thing as before, literally.

lib/libc/locale/xlocale_private.h
205
fuz accepted this revision.Tue, Nov 25, 8:03 PM

LGTM.

This revision is now accepted and ready to land.Tue, Nov 25, 8:03 PM
Closed by commit rG5af240c54bd2: libc: Simplify __get_locale() (authored by des). · Explain WhyWed, Nov 26, 4:57 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG5af240c54bd2: libc: Simplify __get_locale().
des added a commit: rG844f76c2426d: libc: Simplify __get_locale().Fri, Dec 5, 3:09 PM
des added a commit: rG8787b699b036: libc: Simplify __get_locale().Fri, Dec 5, 6:29 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
locale/
6 lines

Diff 167146

View Options

lib/libc/locale/xlocale_private.h

Loading...