em(4): fix capability bounds to access checksum context
ClosedPublic
Actions

Authored by br on Tue, Nov 25, 8:55 AM.

Details

Reviewers

gallatin
kbowling

Group Reviewers

cheri
Restricted Owners Package	(Owns No Changed Paths)

Commits

rG64ee9c166ce5: em(4): fix capability bounds needed to access checksum context.

Summary

Ensure the offp capability bounds cover entire struct with checksum fields.

This is needed for CHERI systems to avoid bounds violation trap, as otherwise offp allowed to dereference 4 bytes of csum_flags field only so bzero failed.

Test Plan

Tested on ARM Morello.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br requested review of this revision.Tue, Nov 25, 8:55 AM

br created this revision.

Herald added a reviewer: cheri. · View Herald TranscriptTue, Nov 25, 8:55 AM

kbowling accepted this revision.Tue, Nov 25, 8:57 AM

This revision is now accepted and ready to land.Tue, Nov 25, 8:57 AM

Closed by commit rG64ee9c166ce5: em(4): fix capability bounds needed to access checksum context. (authored by br). · Explain WhyTue, Nov 25, 9:22 AM

This revision was automatically updated to reflect the committed changes.

br added a commit: rG64ee9c166ce5: em(4): fix capability bounds needed to access checksum context..

Owners added a reviewer: Restricted Owners Package.Tue, Nov 25, 9:22 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Nov 25, 9:22 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

if_em.c

2 lines

Diff 167074

View Options

em(4): fix capability bounds to access checksum contextClosedPublicActions