cp: Fix copying the root directory
ClosedPublic
Actions

Authored by des on Nov 21 2025, 6:03 PM.

Details

Reviewers

Commits

rG54808d50412a: cp: Fix copying the root directory
rGc4843e5805de: cp: Fix copying the root directory
rGfe836c50120d: cp: Fix copying the root directory

Summary

When the source of the copy operation is the root directory, we should
neither append it to the destination path on FTS_D nor trim it back off
on FTS_DP.

PR: 291132
MFC after: 3 days
Fixes: 82fc0d09e862 ("cp: Partly restore symlink folllowing.")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Nov 21 2025, 6:03 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 21 2025, 6:03 PM

des requested review of this revision.Nov 21 2025, 6:03 PM

Harbormaster completed remote builds in B68789: Diff 166921.Nov 21 2025, 6:03 PM

markj accepted this revision.Nov 21 2025, 8:58 PM

This revision is now accepted and ready to land.Nov 21 2025, 8:58 PM

Closed by commit rGfe836c50120d: cp: Fix copying the root directory (authored by des). · Explain WhyNov 22 2025, 12:12 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGfe836c50120d: cp: Fix copying the root directory.

des added a commit: rGc4843e5805de: cp: Fix copying the root directory.Nov 22 2025, 6:43 PM

cperciva added a commit: rG54808d50412a: cp: Fix copying the root directory.Nov 23 2025, 4:40 PM

Revision Contents
Changeset List

Path

Size

bin/

cp/

cp.c

7 lines

tests/

cp_test.sh

15 lines

Diff 166945

View Options

bin/cp/cp.c