newfs_msdos: Improve error messages
ClosedPublic
Actions

Authored by emaste on Nov 9 2025, 7:46 PM.

Tags

None

Referenced Files

	F149062889: D53649.id.diff
	Sun, Mar 22, 2:06 AM

	Unknown Object (File)
	Wed, Mar 18, 4:19 AM

	Unknown Object (File)
	Sat, Mar 14, 8:58 PM

	Unknown Object (File)
	Wed, Mar 11, 10:21 AM

	Unknown Object (File)
	Wed, Mar 11, 9:29 AM

	Unknown Object (File)
	Wed, Mar 11, 8:01 AM

	Unknown Object (File)
	Wed, Mar 11, 7:26 AM

	Unknown Object (File)
	Wed, Mar 11, 6:37 AM

View All 35 Files

Subscribers

None

Details

Reviewers

se
imp
delphij

Commits

rG3602181372ab: newfs_msdos: Improve error messages
rGcf3e1dc5f59e: newfs_msdos: Improve error messages
rGdbb34d496708: newfs_msdos: Improve error messages

Summary

Report overly long OEM string as too long, not just "bad"
Use warn instead of warnx for open or ftruncate failure to report the error string

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 9 2025, 7:46 PM

emaste created this revision.

Looks fine.

This revision is now accepted and ready to land.Nov 9 2025, 10:28 PM

Closed by commit rGdbb34d496708: newfs_msdos: Improve error messages (authored by emaste). · Explain WhyNov 10 2025, 3:02 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGdbb34d496708: newfs_msdos: Improve error messages.

emaste added a commit: rGcf3e1dc5f59e: newfs_msdos: Improve error messages.Nov 17 2025, 2:47 PM

emaste added a commit: rG3602181372ab: newfs_msdos: Improve error messages.

Revision Contents
Changeset List

Path

Size

sbin/

newfs_msdos/

mkfs_msdos.c

6 lines

Diff 166108

View Options

sbin/newfs_msdos/mkfs_msdos.c

newfs_msdos: Improve error messagesClosedPublicActions