newfs_msdos: Improve error messages
ClosedPublic
Actions

Authored by emaste on Sun, Nov 9, 7:46 PM.

Tags

None

Referenced Files

	F135468352: D53649.id.diff
	Mon, Nov 10, 3:04 AM

	F135454551: D53649.id.diff
	Mon, Nov 10, 12:20 AM

	F135454394: D53649.id166088.diff
	Mon, Nov 10, 12:19 AM

	F135451534: D53649.diff
	Sun, Nov 9, 11:49 PM

	F135443316: D53649.diff
	Sun, Nov 9, 10:24 PM

Subscribers

None

Details

Reviewers

se
imp
delphij

Commits

rGdbb34d496708: newfs_msdos: Improve error messages

Summary

Report overly long OEM string as too long, not just "bad"
Use warn instead of warnx for open or ftruncate failure to report the error string

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Sun, Nov 9, 7:46 PM

emaste created this revision.

Looks fine.

This revision is now accepted and ready to land.Sun, Nov 9, 10:28 PM

Closed by commit rGdbb34d496708: newfs_msdos: Improve error messages (authored by emaste). · Explain WhyMon, Nov 10, 3:02 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGdbb34d496708: newfs_msdos: Improve error messages.

Revision Contents
Changeset List

Path

Size

sbin/

newfs_msdos/

mkfs_msdos.c

6 lines

Diff 166108

View Options

sbin/newfs_msdos/mkfs_msdos.c

newfs_msdos: Improve error messagesClosedPublicActions