Page MenuHomeFreeBSD

bsdinstall: use fat32 for ZFS
ClosedPublic

Authored by emaste on Sat, Nov 8, 3:23 PM.
Tags
None
Referenced Files
F135934401: D53642.id166255.diff
Fri, Nov 14, 7:42 AM
F135934392: D53642.id166129.diff
Fri, Nov 14, 7:41 AM
F135923674: D53642.id166255.diff
Fri, Nov 14, 5:05 AM
F135923668: D53642.id.diff
Fri, Nov 14, 5:05 AM
F135923664: D53642.id166129.diff
Fri, Nov 14, 5:05 AM
F135923663: D53642.id166072.diff
Fri, Nov 14, 5:05 AM
F135923643: D53642.id166130.diff
Fri, Nov 14, 5:05 AM
Unknown Object (File)
Fri, Nov 14, 2:27 AM
Subscribers

Details

Summary

EFI implementations must support all of fat12, fat16, and fat32, but other operating systems typically use fat32 for the EFI system partition. The UFS install path also uses fat32. Follow suit in ZFS.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Sat, Nov 8, 3:23 PM

I would, however, like to see this super ugly construct die in a fire. It's way way way over-engineered with little good effect. There's 4 layers of indirections for logging and that's 3 too many.

This revision is now accepted and ready to land.Sat, Nov 8, 5:03 PM

Use -c 1 consistent with the UFS config.

This revision now requires review to proceed.Mon, Nov 10, 2:14 PM

Fixes: 0b7472b3d8d2 ("Mount the EFI system partition (ESP) on newly-installed systems.")

Prior to that commit we newfs'd the ESP with newfs_msdos -F 32 -c 1 -L EFISYS "/dev/$esp" > /dev/null 2>&1

I'm a little nervous about -c 1, but it should be adequate across a reasonable range of partition sizes.

This revision is now accepted and ready to land.Tue, Nov 11, 5:45 PM