acpi: add counters for cumulative time spent in each sleep state.
ClosedPublic
Actions

Authored by adrian on Fri, Nov 7, 4:39 AM.

Details

Reviewers

obiwac
imp
gallatin
adrian

Commits

rG53880f09fb1b: acpi: add counters for cumulative time spent in each sleep state.

Summary

Add this so it can be consumed/graphed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Fri, Nov 7, 4:39 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Nov 7, 4:39 AM

Harbormaster completed remote builds in B68473: Diff 166015.Fri, Nov 7, 4:39 AM

adrian requested review of this revision.Fri, Nov 7, 4:39 AM

adrian added a reviewer: obiwac.Fri, Nov 7, 4:45 AM

Seems legit. It's per cpu already so it should be this simple. Maybe check on the size of the cpu so it doesn't spill to a new cache line

This revision is now accepted and ready to land.Fri, Nov 7, 4:53 AM

Hi @gallatin would you mind helping me eyeball what the cacheline size / offset implications would be for extending the per-CPU ACPI stuff like this? Thanks!

gallatin accepted this revision.Tue, Nov 11, 4:44 PM

Closed by commit rG53880f09fb1b: acpi: add counters for cumulative time spent in each sleep state. (authored by adrian). · Explain WhyTue, Nov 11, 8:45 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG53880f09fb1b: acpi: add counters for cumulative time spent in each sleep state..

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi_cpu.c

30 lines

Diff 166269

View Options

acpi: add counters for cumulative time spent in each sleep state.ClosedPublicActions